sql: support binary format for DInterval#25242
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 2, 2018
Merged
Conversation
Member
|
This change is |
knz
approved these changes
May 2, 2018
| if len(b) < 16 { | ||
| return nil, errors.Errorf("interval requires 16 bytes for binary format") | ||
| } | ||
| nanos := int64(binary.BigEndian.Uint64(b)) / int64(time.Nanosecond) * int64(time.Microsecond) |
Contributor
There was a problem hiding this comment.
make the grouping explicit (a / b) * c
Contributor
Author
|
TFTR! bors r+ |
Fixes cockroachdb#24525. Release note (sql change): The binary postgres wire format is now supported for intervals.
Contributor
Canceled |
Contributor
Author
|
My bad - missed a linter fix bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 2, 2018
24958: sql: Add support for parsing ALTER COLUMN TYPE r=bobvawter a=bobvawter This change adds SQL parsing support for the proposed ALTER COLUMN TYPE syntax in RFC #24703. It still returns an unimplemented error message to the caller. Release note: none 25242: sql: support binary format for DInterval r=justinj a=justinj Fixes #24525. Release note (sql change): The binary postgres wire format is now supported for intervals. Co-authored-by: Bob Vawter <bob@cockroachlabs.com> Co-authored-by: Justin Jaffray <justin@cockroachlabs.com>
Contributor
Build succeeded |
This was referenced Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24525.
Release note (sql change): The binary postgres wire format is now supported for
intervals.