sql: Add support for parsing ALTER COLUMN TYPE#24958
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 2, 2018
bobvawter:alter
Merged
sql: Add support for parsing ALTER COLUMN TYPE#24958craig[bot] merged 1 commit intocockroachdb:masterfrom bobvawter:alter
craig[bot] merged 1 commit intocockroachdb:masterfrom
bobvawter:alter
Conversation
Member
|
This change is |
Contributor
|
The BNF generators (diagrams.go in cmd/docgen) need to be updated. I can help out if needed: they are kinda annoying. For instance, add_column.bnf needs to be unchanged since this isn't an add column. Also add me as a reviewer next time so I see these PRs. I just found it while looking for other stuff. Review status: 0 of 10 files reviewed at latest revision, all discussions resolved. pkg/sql/sem/tree/alter_table.go, line 164 at r1 (raw file):
This needs tests. See TestParse in parse_test.go. Comments from Reviewable |
This change adds SQL parsing support for the proposed ALTER COLUMN TYPE syntax in RFC #24703. It still returns an unimplemented error message to the caller. Release note: None
Contributor
Author
|
PTAL: Updated docgen and verified that the resulting BNF result in pretty pictures. |
madelynnblue
approved these changes
May 2, 2018
Contributor
Author
|
bors r+ |
Contributor
Canceled (will resume) |
craig bot
pushed a commit
that referenced
this pull request
May 2, 2018
24958: sql: Add support for parsing ALTER COLUMN TYPE r=bobvawter a=bobvawter This change adds SQL parsing support for the proposed ALTER COLUMN TYPE syntax in RFC #24703. It still returns an unimplemented error message to the caller. Release note: none 25242: sql: support binary format for DInterval r=justinj a=justinj Fixes #24525. Release note (sql change): The binary postgres wire format is now supported for intervals. Co-authored-by: Bob Vawter <bob@cockroachlabs.com> Co-authored-by: Justin Jaffray <justin@cockroachlabs.com>
Contributor
Build succeeded |
benesch
added a commit
to benesch/cockroach
that referenced
this pull request
Jun 6, 2018
The last reference to opt_collate_clause was removed in cockroachdb#24958. Normally this causes goyacc to throw a "rule not reduced" error, but for some reason it's not happening until I make some unrelated changes. (Probably a bug in goyacc.) Take the opportunity to clean up the naming scheme, too: opt_collate is used where optional collation is supported, while opt_collate_unimpl is used where optional collation is not supported. Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds SQL parsing support for the proposed ALTER COLUMN TYPE syntax
in RFC #24703. It still returns an unimplemented error message to the caller.
Release note: none