build: make make ignore go files in testdata directories#25215
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 1, 2018
Merged
build: make make ignore go files in testdata directories#25215craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Otherwise the special file in pkg/cmd/prereqs/testdata will break. Ideally we'll want to use the 'prereqs' tool instead. For now this will do. Release note: none
Member
|
This change is |
Contributor
Author
|
thanks! bors r+ |
Contributor
Build failed (retrying...) |
craig bot
pushed a commit
that referenced
this pull request
May 1, 2018
25190: sql: fix information_schema.constraint_column_usage.constraint_schema r=nvanbenschoten a=nvanbenschoten Found while working on #22298. This column was missed in #22753. It was displaying each constraint's database instead of each constraint's schema. Release note (bug fix): The constraint_schema column in information_schema.constraint_column_usage now displays the constraint's schema instead of its catalog. 25215: build: make make ignore go files in testdata directories r=knz a=knz Otherwise the special file in pkg/cmd/prereqs/testdata will break. Ideally we'll want to use the 'prereqs' tool instead. For now this will do. Release note: none Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com> Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the special file in pkg/cmd/prereqs/testdata will break.
Ideally we'll want to use the 'prereqs' tool instead. For now this will do.
Release note: none