Skip to content

sql: fix information_schema.constraint_column_usage.constraint_schema#25190

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/todo
May 1, 2018
Merged

sql: fix information_schema.constraint_column_usage.constraint_schema#25190
craig[bot] merged 1 commit intocockroachdb:masterfrom
nvb:nvanbenschoten/todo

Conversation

@nvb
Copy link
Copy Markdown
Contributor

@nvb nvb commented Apr 30, 2018

Found while working on #22298.

This column was missed in #22753. It was displaying each constraint's
database instead of each constraint's schema.

Release note (bug fix): The constraint_schema column in
information_schema.constraint_column_usage now displays the
constraint's schema instead of its catalog.

Found while working on cockroachdb#22298.

This column was missed in cockroachdb#22753. It was displaying each constraint's
database instead of each constraint's schema.

Release note (bug fix): The constraint_schema column in
information_schema.constraint_column_usage now displays the
constraint's schema instead of its catalog.
@nvb nvb requested review from a team and knz April 30, 2018 21:35
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@knz
Copy link
Copy Markdown
Contributor

knz commented Apr 30, 2018

maybe backport?

@knz knz added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-pgcompat Semantic compatibility with PostgreSQL labels Apr 30, 2018
@nvb
Copy link
Copy Markdown
Contributor Author

nvb commented May 1, 2018

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 1, 2018

Build failed (retrying...)

@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 1, 2018

Build failed (retrying...)

craig bot pushed a commit that referenced this pull request May 1, 2018
25190: sql: fix information_schema.constraint_column_usage.constraint_schema r=nvanbenschoten a=nvanbenschoten

Found while working on #22298.

This column was missed in #22753. It was displaying each constraint's
database instead of each constraint's schema.

Release note (bug fix): The constraint_schema column in
information_schema.constraint_column_usage now displays the
constraint's schema instead of its catalog.

25215: build: make make ignore go files in testdata directories r=knz a=knz

Otherwise the special file in pkg/cmd/prereqs/testdata will break.

Ideally we'll want to use the 'prereqs' tool instead. For now this will do.

Release note: none

Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
Co-authored-by: Raphael 'kena' Poss <knz@cockroachlabs.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented May 1, 2018

Build succeeded

@craig craig bot merged commit e719290 into cockroachdb:master May 1, 2018
craig bot pushed a commit that referenced this pull request May 2, 2018
25220: backport-2.0: sql: fix information_schema.constraint_column_usage.constraint_schema r=nvanbenschoten a=nvanbenschoten

Backport 1/1 commits from #25190.

/cc @cockroachdb/release

---

Found while working on #22298.

This column was missed in #22753. It was displaying each constraint's
database instead of each constraint's schema.

Release note (bug fix): The constraint_schema column in
information_schema.constraint_column_usage now displays the
constraint's schema instead of its catalog.


Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
@nvb nvb deleted the nvanbenschoten/todo branch May 2, 2018 14:16
@knz knz added the docs-todo label May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) docs-todo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants