sql: name the transaction settings like PG does#20264
sql: name the transaction settings like PG does#20264knz merged 2 commits intocockroachdb:masterfrom
Conversation
|
This change is |
|
Might want to cherry-pick to 1.1, what do you think? |
a87ebb0 to
ab26323
Compare
In PostgreSQL, the transaction isolation level is reported by the session variable `transaction_isolation` (two words separated by an underscore), not `transaction isolation level` (three words separated by spaces). Also the transaction level is reported in lowercase. Clients actually care about this stuff. This patch makes CockroachDB behave more like PG. This also aligns `transaction_priority` and `transaction_status` (CockroachDB extension) with `transaction_isolation` (PG standard setting), for more consistency in UX. Patch series: ["Just because you are unique does not mean you are useful."](https://duckduckgo.com/?q=just+because+you+are+unique+does+not+mean+you+are+useful&iar=images) ---- Release note (sql): the session settings `transaction isolation level`, `transaction priority` and `transaction status` are now called `transaction_isolation`, `transaction_priority` and `transaction_status` for better compatibility with PostgreSQL.
|
@jordanlewis please let the first commit here inform your change in #20274. |
|
Reviewed 1 of 1 files at r1, 11 of 11 files at r2. pkg/sql/vars.go, line 243 at r1 (raw file):
nit that's not worth another round of CI: inspired by, not from Comments from Reviewable |
|
TFYR |
|
Perhaps you can fix the grammar in your #20274 patch? |
|
New to the whole github thing. CCL v1.1.3 @ 2017/11/27 13:59:10 (go1.8.3) |
|
Afraid it's not in any release yet, but it'll be in the next 1.2 alpha release scheduled for December 4: #20272 |
|
@jordanlewis do you reckon we should cherry pick this onto 1.1? |
|
@knz yes. There is some danger because the casing of the settings changed, but if anyone was using those we would likely have heard complaints about the PG incompatibility already. |
Fixes #18506.
In PostgreSQL, the transaction isolation level is reported by the
session variable
transaction_isolation(two words separated by anunderscore), not
transaction isolation level(three words separatedby spaces). Also the iso level is reported in lowercase.
Clients actually care about this stuff.
This patch makes CockroachDB behave more like PG.
This also aligns
transaction_priorityandtransaction_status(CockroachDB extension) with
transaction_isolation(PG standardsetting), for more consistency in UX.
Release note (sql): the session settings
transaction isolation level,transaction priorityandtransaction statusare now calledtransaction_isolation,transaction_priorityandtransaction_statusfor better compatibility with PostgreSQL.