Skip to content

sql: some more postgres compat for FDW support#20274

Merged
jordanlewis merged 2 commits intocockroachdb:masterfrom
jordanlewis:fdw-compat
Nov 28, 2017
Merged

sql: some more postgres compat for FDW support#20274
jordanlewis merged 2 commits intocockroachdb:masterfrom
jordanlewis:fdw-compat

Conversation

@jordanlewis
Copy link
Copy Markdown
Member

@jordanlewis jordanlewis commented Nov 27, 2017

  • support ABORT [TRANSACTION | WORK]
  • support INTERVALSTYLE

Updates #20249.
Closes #20271.

@jordanlewis jordanlewis requested review from a team, justinj and knz November 27, 2017 17:02
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Nov 27, 2017

This change is Reviewable

@knz knz mentioned this pull request Nov 27, 2017
Merged
@knz
Copy link
Copy Markdown
Contributor

knz commented Nov 27, 2017

👍 on the compat change!

👎 on exposing the ABORT syntax in docs

Also see #20264 for comments on the new session var

Reviewed 3 of 3 files at r1, 5 of 5 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.

pkg/sql/parser/sql.y, line 3594 at r1 (raw file):

| commit_stmt   // EXTEND WITH HELP: COMMIT
| rollback_stmt // EXTEND WITH HELP: ROLLBACK
| abort_stmt    // EXTEND WITH HELP: ABORT

I'd recommend against EXTEND WITH HELP here if you're not also providing // %Help below.
Also since this is just syntactic sugar, what about no contextual help at all.

Also: /* SKIP DOC */ here.

Comments from Reviewable

@jordanlewis
sql: support ABORT [TRANSACTION | WORK]
9dc288f 
For pg compatibility. They're synonyms of ROLLBACK.

Release note (sql change): support ABORT TRANSACTION for Postgres
compatibility.
@jordanlewis
Copy link
Copy Markdown
Member Author

jordanlewis commented Nov 27, 2017

Done. PTAL.

knz
knz reviewed Nov 27, 2017
View reviewed changes
pkg/sql/vars.go Outdated
`extra_float_digits`: nopVar,

// Supported for PG compatibility only.
// See https://www.postgresql.org/docs/9.4/static/runtime-config-client.html
Copy link
Copy Markdown
Contributor

@knz knz Nov 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not worth a CI run, but next time please grab the most recent version of the doc link.

@jordanlewis
sql: support intervalstyle var as read-only
af33e65 
For pg compat.

Release note (sql change): support intervalstyle for Postgres
compatibility.
@jordanlewis
Copy link
Copy Markdown
Member Author

jordanlewis commented Nov 27, 2017

Review status: 1 of 8 files reviewed at latest revision, 2 unresolved discussions.

pkg/sql/vars.go, line 233 at r4 (raw file):

Previously, knz (kena) wrote…

Not worth a CI run, but next time please grab the most recent version of the doc link.

Done.

Comments from Reviewable

@jordanlewis jordanlewis merged commit 2c1b5ec into cockroachdb:master Nov 28, 2017
@jordanlewis jordanlewis deleted the fdw-compat branch November 28, 2017 04:01
@jseldess jseldess mentioned this pull request Dec 13, 2017
Closed
@bdarnell bdarnell mentioned this pull request Apr 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinj justinj Awaiting requested review from justinj

1 more reviewer

@knz knz knz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jordanlewis @cockroach-teamcity @knz