kvserver: thread in correct engine when destroying and subsuming replicas#161454
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jan 21, 2026
Merged
kvserver: thread in correct engine when destroying and subsuming replicas#161454craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
pav-kv
approved these changes
Jan 20, 2026
Collaborator
pav-kv
left a comment
There was a problem hiding this comment.
LGTM % first commit seeming unnecessary.
Collaborator
|
Link the issue in the PR desc? |
Release note: None
Release note: None
15173cd to
ed00ed6
Compare
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Collaborator
Author
|
Dropped the first commit. bors r=pav-kv |
Contributor
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Mar 4, 2026
Add a project-level code review skill that orchestrates multiple review aspects (redactability, commit structure, red/green testing, PR descriptions, general quality) by referencing existing rules and the commit-arc skill rather than duplicating their content. Includes support for posting batched GitHub reviews with inline line comments via the API. Also add a conventions rule covering PR descriptions, Bazel build files, metrics, Go conventions, and CI checks. Note: .github/workflows/pr-analyzer-threestage.yml already runs an AI-powered bug-screening pipeline on PRs. That workflow is deliberately narrow — it only flags likely bugs and uses a three-stage confidence filter to minimize noise. This skill is broader (reviewability, commit structure, redactability, etc.) and designed for interactive use. In the future, the CI workflow could invoke this skill to get structured, aspect-based review while keeping its conservative posting threshold. Example reviews generated by this skill: - PR cockroachdb#164658 (63-commit MMA repair): https://gist.github.com/tbg/ba4d528bcfa27cdae9ca587f91fb7178 - PR cockroachdb#164792 (physical modeling): https://gist.github.com/tbg/1d78a0c496069f18ec35a2b551483052 - PR cockroachdb#164677 (connection retry test): https://gist.github.com/tbg/69ec2eea0c4ab5d794a135fa62e551dc - PR cockroachdb#79134 (SKIP LOCKED): https://gist.github.com/tbg/052dae1e3f6449811fca92e275905f1f - PR cockroachdb#161454 (engine separation): https://gist.github.com/tbg/63ef958edd355fb166493b008a0291d5 Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Mar 4, 2026
Add a project-level code review skill that orchestrates multiple review aspects (redactability, commit structure, red/green testing, PR descriptions, general quality) by referencing existing rules and the commit-arc skill rather than duplicating their content. Includes support for posting batched GitHub reviews with inline line comments via the API. Also add a conventions rule covering PR descriptions, Bazel build files, metrics, Go conventions, and CI checks. Note: .github/workflows/pr-analyzer-threestage.yml already runs an AI-powered bug-screening pipeline on PRs. That workflow is deliberately narrow — it only flags likely bugs and uses a three-stage confidence filter to minimize noise. This skill is broader (reviewability, commit structure, redactability, etc.) and designed for interactive use. In the future, the CI workflow could invoke this skill to get structured, aspect-based review while keeping its conservative posting threshold. Example reviews generated by this skill: - PR cockroachdb#164658 (63-commit MMA repair): https://gist.github.com/tbg/ba4d528bcfa27cdae9ca587f91fb7178 - PR cockroachdb#164792 (physical modeling): https://gist.github.com/tbg/1d78a0c496069f18ec35a2b551483052 - PR cockroachdb#164677 (connection retry test): https://gist.github.com/tbg/69ec2eea0c4ab5d794a135fa62e551dc - PR cockroachdb#79134 (SKIP LOCKED): https://gist.github.com/tbg/052dae1e3f6449811fca92e275905f1f - PR cockroachdb#161454 (engine separation): https://gist.github.com/tbg/63ef958edd355fb166493b008a0291d5 Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Mar 4, 2026
Add a project-level code review skill that orchestrates multiple review aspects (redactability, commit structure, red/green testing, PR descriptions, general quality) by referencing existing rules and the commit-arc skill rather than duplicating their content. Includes support for posting batched GitHub reviews with inline line comments via the API. Also add a conventions rule covering PR descriptions, Bazel build files, metrics, Go conventions, and CI checks. Note: .github/workflows/pr-analyzer-threestage.yml already runs an AI-powered bug-screening pipeline on PRs. That workflow is deliberately narrow — it only flags likely bugs and uses a three-stage confidence filter to minimize noise. This skill is broader (reviewability, commit structure, redactability, etc.) and designed for interactive use. In the future, the CI workflow could invoke this skill to get structured, aspect-based review while keeping its conservative posting threshold. Example reviews generated by this skill: - PR cockroachdb#164658 (63-commit MMA repair): https://gist.github.com/tbg/ba4d528bcfa27cdae9ca587f91fb7178 - PR cockroachdb#164792 (physical modeling): https://gist.github.com/tbg/1d78a0c496069f18ec35a2b551483052 - PR cockroachdb#164677 (connection retry test): https://gist.github.com/tbg/69ec2eea0c4ab5d794a135fa62e551dc - PR cockroachdb#79134 (SKIP LOCKED): https://gist.github.com/tbg/052dae1e3f6449811fca92e275905f1f - PR cockroachdb#161454 (engine separation): https://gist.github.com/tbg/63ef958edd355fb166493b008a0291d5 Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Mar 4, 2026
Add a project-level code review skill that orchestrates multiple review aspects (redactability, commit structure, red/green testing, PR descriptions, general quality) by referencing existing rules and the commit-arc skill rather than duplicating their content. Includes support for posting batched GitHub reviews with inline line comments via the API. Also add a conventions rule covering PR descriptions, Bazel build files, metrics, Go conventions, and CI checks. Note: .github/workflows/pr-analyzer-threestage.yml already runs an AI-powered bug-screening pipeline on PRs. That workflow is deliberately narrow — it only flags likely bugs and uses a three-stage confidence filter to minimize noise. This skill is broader (reviewability, commit structure, redactability, etc.) and designed for interactive use. In the future, the CI workflow could invoke this skill to get structured, aspect-based review while keeping its conservative posting threshold. Example reviews generated by this skill: - PR cockroachdb#164658 (63-commit MMA repair): https://gist.github.com/tbg/ba4d528bcfa27cdae9ca587f91fb7178 - PR cockroachdb#164792 (physical modeling): https://gist.github.com/tbg/1d78a0c496069f18ec35a2b551483052 - PR cockroachdb#164677 (connection retry test): https://gist.github.com/tbg/69ec2eea0c4ab5d794a135fa62e551dc - PR cockroachdb#79134 (SKIP LOCKED): https://gist.github.com/tbg/052dae1e3f6449811fca92e275905f1f - PR cockroachdb#161454 (engine separation): https://gist.github.com/tbg/63ef958edd355fb166493b008a0291d5 Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
tbg
added a commit
to tbg/cockroach
that referenced
this pull request
Mar 4, 2026
Add a project-level code review skill that orchestrates multiple review aspects (redactability, commit structure, red/green testing, PR descriptions, general quality) by referencing existing rules and the commit-arc skill rather than duplicating their content. Includes support for posting batched GitHub reviews with inline line comments via the API. Also add a conventions rule covering PR descriptions, Bazel build files, metrics, Go conventions, and CI checks. Note: .github/workflows/pr-analyzer-threestage.yml already runs an AI-powered bug-screening pipeline on PRs. That workflow is deliberately narrow — it only flags likely bugs and uses a three-stage confidence filter to minimize noise. This skill is broader (reviewability, commit structure, redactability, etc.) and designed for interactive use. In the future, the CI workflow could invoke this skill to get structured, aspect-based review while keeping its conservative posting threshold. Example reviews generated by this skill: - PR cockroachdb#164658 (63-commit MMA repair): https://gist.github.com/tbg/ba4d528bcfa27cdae9ca587f91fb7178 - PR cockroachdb#164792 (physical modeling): https://gist.github.com/tbg/1d78a0c496069f18ec35a2b551483052 - PR cockroachdb#164677 (connection retry test): https://gist.github.com/tbg/69ec2eea0c4ab5d794a135fa62e551dc - PR cockroachdb#79134 (SKIP LOCKED): https://gist.github.com/tbg/052dae1e3f6449811fca92e275905f1f - PR cockroachdb#161454 (engine separation): https://gist.github.com/tbg/63ef958edd355fb166493b008a0291d5 Epic: none Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.
Informs #161059