-
Notifications
You must be signed in to change notification settings - Fork 4.1k
kvserver: logically separate engines in apply stack #161059
Copy link
Copy link
Closed
Labels
A-kv-replicationRelating to Raft, consensus, and coordination.Relating to Raft, consensus, and coordination.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-kvKV TeamKV Teambranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.
Description
After #160565 merges, similarly support the lazily created log engine batches in other write paths that replicaAppBatch is responsible for (see all users of the batch that need a log engine access):
- replica destruction when applying a merge
- replica destruction when applying a config change that removes our replica
- log truncation
Nuances (maybe more during reviews):
- The log truncation path is for the tightly coupled truncations. It won't be used with separated engines. Need to consider whether we want to skip it, or support half-legally (only to unblock some testing).
- The replica destruction in config changes has a condition which would be good to get rid of.
Epic: CRDB-55220
Jira issue: CRDB-58685
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-kv-replicationRelating to Raft, consensus, and coordination.Relating to Raft, consensus, and coordination.C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-kvKV TeamKV Teambranch-masterFailures and bugs on the master branch.Failures and bugs on the master branch.