kvserver: add ability to lazily initialize Raft engine batches#160565
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jan 17, 2026
Merged
kvserver: add ability to lazily initialize Raft engine batches#160565craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
pav-kv
reviewed
Jan 12, 2026
Collaborator
pav-kv
left a comment
There was a problem hiding this comment.
Looks good, LGTMable in the next iteration.
pkg/kv/kvserver/replica_app_batch.go
Outdated
| } | ||
|
|
||
| // Commit the Raft batch to Pebble, if it exists. Note unlike batches to the | ||
| // State engine, we always sync writes to the Raft engine. |
Collaborator
There was a problem hiding this comment.
TODO to revisit how the state engine is synced below? In separated engines mode, we can skip the second sync entirely by design (unless there are some corner cases to yet fix).
Collaborator
Author
There was a problem hiding this comment.
Actually, let's leave this to a subsequent PR. Need to understand some of the commentary here better.
3 tasks
cc857c9 to
d897fb1
Compare
arulajmani
commented
Jan 16, 2026
Collaborator
Author
arulajmani
left a comment
There was a problem hiding this comment.
@arulajmani made 6 comments and resolved 1 discussion.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @pav-kv).
pkg/kv/kvserver/replica_app_batch.go
Outdated
| } | ||
|
|
||
| // Commit the Raft batch to Pebble, if it exists. Note unlike batches to the | ||
| // State engine, we always sync writes to the Raft engine. |
Collaborator
Author
There was a problem hiding this comment.
Actually, let's leave this to a subsequent PR. Need to understand some of the commentary here better.
pav-kv
approved these changes
Jan 16, 2026
d897fb1 to
b679ae4
Compare
Collaborator
Author
|
TFTR! bors r=pav-kv |
Previously, we were not distinguishing between the State engine and Raft engine when preparing a split. This patch fixes that, by adding the ability to lazily initialize a Raft batch, which will be written to the Raft engine, and passing it to splitPreApply. Epic: none Release note: None
b679ae4 to
494843c
Compare
Contributor
|
Canceled. |
Collaborator
Author
|
Reverted the comment wrap. bors r=pav-kv |
craig bot
pushed a commit
that referenced
this pull request
Jan 16, 2026
160565: kvserver: add ability to lazily initialize Raft engine batches r=pav-kv a=arulajmani Previously, we were not distinguishing between the State engine and Raft engine when preparing a split. This patch fixes that, by adding the ability to lazily initialize a Raft batch, which will be written to the Raft engine, and passing it to splitPreApply. Epic: none Release note: None Co-authored-by: Arul Ajmani <arulajmani@gmail.com>
Contributor
|
Build failed: |
Collaborator
|
bors retry |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we were not distinguishing between the State engine and Raft engine when preparing a split. This patch fixes that, by adding the ability to lazily initialize a Raft batch, which will be written to the Raft engine, and passing it to splitPreApply.
Epic: none
Release note: None