Skip to content

ci: make env vars across cloud providers consistent for roachtest#156958

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
williamchoe3:wchoe/nightly-roachtest-env-vars
Nov 6, 2025
Merged

ci: make env vars across cloud providers consistent for roachtest#156958
craig[bot] merged 1 commit intocockroachdb:masterfrom
williamchoe3:wchoe/nightly-roachtest-env-vars

Conversation

@williamchoe3
Copy link
Copy Markdown
Contributor

@williamchoe3 williamchoe3 commented Nov 5, 2025

Noticed some inconsistency, this aligns gce azure aws ibm
Just with EXTRA_ROACHTEST_ARGS and ALWAYS_COLLECT_ARTIFACTS

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@williamchoe3 williamchoe3 force-pushed the wchoe/nightly-roachtest-env-vars branch from 35c559f to c3ccfb0 Compare November 5, 2025 20:11
@williamchoe3 williamchoe3 marked this pull request as ready for review November 5, 2025 20:11
@williamchoe3 williamchoe3 requested a review from a team as a code owner November 5, 2025 20:11
@williamchoe3
Copy link
Copy Markdown
Contributor Author

TFTR!

bors r=srosenberg,rickystewart

craig bot pushed a commit that referenced this pull request Nov 5, 2025
156691: sql: fix a couple of spots where we missed JSONPATH and LTREE r=yuzefovich a=yuzefovich

We forgot to include `DJsonpath` and `DLTree` into some of the type switches when converting datums into string format for miscellaneous builtins. This is now fixed. I decided to omit a release note given these seem like edge cases.

Fixes: #156511.
Fixes: #156611.
Release note: None

156954: roachtest/npgsql: skip on s390x r=fqazi a=fqazi

Previously, the npgsql test was running on S390X, which doesn't have the required binaries. To address this, this patch excludes the IBM cloud.

Fixes: #156622

Release note: None

156958: ci: make env vars across cloud providers consistent for roachtest r=srosenberg,rickystewart a=williamchoe3

Noticed some inconsistency, this aligns gce azure aws ibm
Just with `EXTRA_ROACHTEST_ARGS` and `ALWAYS_COLLECT_ARTIFACTS`

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
Co-authored-by: William Choe <williamchoe3@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 5, 2025

Build failed (retrying...):

craig bot pushed a commit that referenced this pull request Nov 5, 2025
155564: *: remove remaining references of the meta issue for secondary test tenants r=yuzefovich a=yuzefovich

**logictest: reference separate issue for disabling test tenant**

**base: remove TODOTestTenantDisabled**

All test tenant skips now have specific issues.

***: remove remaining references of the meta issue**

Going forward, #76378 will be the meta issue tracking all remaining work
for investigating and enabling test tenants across our tests. This
commit removes the last explicit mentions of the issue by replacing with
specific ones or enabling test tenants on some packages that happened to
just work.

Epic: CRDB-48945
Release note: None

156593: roachtest/pg_regress: accept recent diff and disable jobs notice r=yuzefovich a=yuzefovich

Fixes: #155302.
Release note: None

156954: roachtest/npgsql: skip on s390x r=fqazi a=fqazi

Previously, the npgsql test was running on S390X, which doesn't have the required binaries. To address this, this patch excludes the IBM cloud.

Fixes: #156622

Release note: None

156958: ci: make env vars across cloud providers consistent for roachtest r=srosenberg,rickystewart a=williamchoe3

Noticed some inconsistency, this aligns gce azure aws ibm
Just with `EXTRA_ROACHTEST_ARGS` and `ALWAYS_COLLECT_ARTIFACTS`

Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
Co-authored-by: William Choe <williamchoe3@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 5, 2025

Build failed (retrying...):

@williamchoe3
Copy link
Copy Markdown
Contributor Author

bors retry

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 5, 2025

Already running a review

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 6, 2025

@craig craig bot merged commit d8af269 into cockroachdb:master Nov 6, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants