ci: make env vars across cloud providers consistent for roachtest#156958
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 6, 2025
Merged
Conversation
Member
Epic: None Release note: None
35c559f to
c3ccfb0
Compare
srosenberg
approved these changes
Nov 5, 2025
rickystewart
approved these changes
Nov 5, 2025
Contributor
Author
|
TFTR! bors r=srosenberg,rickystewart |
craig bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
156691: sql: fix a couple of spots where we missed JSONPATH and LTREE r=yuzefovich a=yuzefovich We forgot to include `DJsonpath` and `DLTree` into some of the type switches when converting datums into string format for miscellaneous builtins. This is now fixed. I decided to omit a release note given these seem like edge cases. Fixes: #156511. Fixes: #156611. Release note: None 156954: roachtest/npgsql: skip on s390x r=fqazi a=fqazi Previously, the npgsql test was running on S390X, which doesn't have the required binaries. To address this, this patch excludes the IBM cloud. Fixes: #156622 Release note: None 156958: ci: make env vars across cloud providers consistent for roachtest r=srosenberg,rickystewart a=williamchoe3 Noticed some inconsistency, this aligns gce azure aws ibm Just with `EXTRA_ROACHTEST_ARGS` and `ALWAYS_COLLECT_ARTIFACTS` Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com> Co-authored-by: William Choe <williamchoe3@gmail.com>
Contributor
|
Build failed (retrying...): |
craig bot
pushed a commit
that referenced
this pull request
Nov 5, 2025
155564: *: remove remaining references of the meta issue for secondary test tenants r=yuzefovich a=yuzefovich **logictest: reference separate issue for disabling test tenant** **base: remove TODOTestTenantDisabled** All test tenant skips now have specific issues. ***: remove remaining references of the meta issue** Going forward, #76378 will be the meta issue tracking all remaining work for investigating and enabling test tenants across our tests. This commit removes the last explicit mentions of the issue by replacing with specific ones or enabling test tenants on some packages that happened to just work. Epic: CRDB-48945 Release note: None 156593: roachtest/pg_regress: accept recent diff and disable jobs notice r=yuzefovich a=yuzefovich Fixes: #155302. Release note: None 156954: roachtest/npgsql: skip on s390x r=fqazi a=fqazi Previously, the npgsql test was running on S390X, which doesn't have the required binaries. To address this, this patch excludes the IBM cloud. Fixes: #156622 Release note: None 156958: ci: make env vars across cloud providers consistent for roachtest r=srosenberg,rickystewart a=williamchoe3 Noticed some inconsistency, this aligns gce azure aws ibm Just with `EXTRA_ROACHTEST_ARGS` and `ALWAYS_COLLECT_ARTIFACTS` Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com> Co-authored-by: William Choe <williamchoe3@gmail.com>
Contributor
|
Build failed (retrying...): |
Contributor
Author
|
bors retry |
Contributor
|
Already running a review |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed some inconsistency, this aligns gce azure aws ibm
Just with
EXTRA_ROACHTEST_ARGSandALWAYS_COLLECT_ARTIFACTS