Skip to content

*: remove remaining references of the meta issue for secondary test tenants#155564

Merged
craig[bot] merged 3 commits intocockroachdb:masterfrom
yuzefovich:tenant-sql
Nov 6, 2025
Merged

*: remove remaining references of the meta issue for secondary test tenants#155564
craig[bot] merged 3 commits intocockroachdb:masterfrom
yuzefovich:tenant-sql

Conversation

@yuzefovich
Copy link
Copy Markdown
Member

@yuzefovich yuzefovich commented Oct 17, 2025

logictest: reference separate issue for disabling test tenant

base: remove TODOTestTenantDisabled

All test tenant skips now have specific issues.

*: remove remaining references of the meta issue

Going forward, #76378 will be the meta issue tracking all remaining work
for investigating and enabling test tenants across our tests. This
commit removes the last explicit mentions of the issue by replacing with
specific ones or enabling test tenants on some packages that happened to
just work.

Epic: CRDB-48945
Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@yuzefovich yuzefovich requested review from ZhouXing19 and removed request for ZhouXing19 October 17, 2025 04:33
@yuzefovich
Copy link
Copy Markdown
Member Author

Jane, sorry, please ignore this one.

@yuzefovich yuzefovich force-pushed the tenant-sql branch 10 times, most recently from 335f3b4 to 86e1cc2 Compare October 23, 2025 19:00
@github-actions
Copy link
Copy Markdown
Contributor

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

After you review the findings, please tag the issue as follows:

  • If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
  • If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

@github-actions github-actions bot added the o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. label Oct 24, 2025
@yuzefovich yuzefovich added O-No-AI-Review Prevents AI Review from running O-AI-Review-Not-Helpful AI reviewer produced result which was incorrect or unhelpful labels Oct 24, 2025
@cockroachdb cockroachdb deleted a comment from blathers-crl bot Oct 24, 2025
@yuzefovich yuzefovich force-pushed the tenant-sql branch 10 times, most recently from 712ad9e to 39cae7b Compare October 29, 2025 23:19
@yuzefovich yuzefovich requested review from Abhinav1299, aa-joshi, andyyang890, angles-n-daemons, arjunmahishi, dt and mw5h and removed request for a team and angles-n-daemons November 4, 2025 01:42
Copy link
Copy Markdown
Contributor

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@mgartner reviewed 55 of 55 files at r1, 5 of 5 files at r2, 17 of 17 files at r3, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mw5h)

@yuzefovich
Copy link
Copy Markdown
Member Author

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 5, 2025

Build failed (retrying...):

@yuzefovich
Copy link
Copy Markdown
Member Author

Oops, merge skew, need to rebase.

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 6, 2025

Canceled.

All test tenant skips now have specific issues.

Release note: None
Going forward, 76378 will be the meta issue tracking all remaining work
for investigating and enabling test tenants across our tests. This
commit removes the last explicit mentions of the issue by replacing with
specific ones or enabling test tenants on some packages that happened to
just work.

Release note: None
@yuzefovich
Copy link
Copy Markdown
Member Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Nov 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-AI-Review-Not-Helpful AI reviewer produced result which was incorrect or unhelpful o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. O-No-AI-Review Prevents AI Review from running v26.1.0-prerelease

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants