workload/tpch: add a couple of missed values for fixtures generation#156002
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 24, 2025
Merged
workload/tpch: add a couple of missed values for fixtures generation#156002craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
DrewKimball
approved these changes
Oct 23, 2025
Collaborator
DrewKimball
left a comment
There was a problem hiding this comment.
@DrewKimball reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Member
Author
|
TFTR and for the nudge to look into this! For posterity, I also updated the backup we use in bors r+ |
Member
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
155783: sql: several preliminary changes to making tests work with secondary tenants r=yuzefovich a=yuzefovich This PR contains several commits which audit tests in `pkg/sql` directory to ensure the right JobRegistry, codec, LeaseManager, and PGUrl are used. Almost all were pretty mechanical changes. Note that no new tests are enabled with secondary tenants yet - this will be done separately. Epic: CRDB-48945 156002: workload/tpch: add a couple of missed values for fixtures generation r=yuzefovich a=yuzefovich When we added the fixtures generation of TPCH spec, we forgot a couple of values - one for "priorities" and one for "containers". This commit fixes that omission. In particular, missing priority value made us return 4 rows instead of 5 for Q4, and the expectation has been adjusted accordingly. Note that this omission was exposed via a roachtest that uses correctly generated fixtures of SF 100. Fixes: #155834. Release note: None 156008: Revert "publish-artifacts: change GCS latest key prefix for Workload … r=rail a=williamchoe3 Original PR: #155789 Reverting to split into 2 commits for easier backport Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: William Choe <williamchoe3@gmail.com>
Contributor
|
Build failed (retrying...): |
Member
Author
|
Oops, one test needs an update. bors r- |
Contributor
|
Canceled. |
When we added the fixtures generation of TPCH spec, we forgot a couple of values - one for "priorities" and one for "containers". This commit fixes that omission. In particular, missing priority value made us return 4 rows instead of 5 for Q4, and the expectation has been adjusted accordingly. Note that this omission was exposed via a roachtest that uses correctly generated fixtures of SF 100. Release note: None
c19cded to
f067985
Compare
Member
Author
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
155988: sqlccl: ignore known bug in TestExplainGist r=yuzefovich a=yuzefovich See: #125620 Informs: #155948 Release note: None 156002: workload/tpch: add a couple of missed values for fixtures generation r=yuzefovich a=yuzefovich When we added the fixtures generation of TPCH spec, we forgot a couple of values - one for "priorities" and one for "containers". This commit fixes that omission. In particular, missing priority value made us return 4 rows instead of 5 for Q4, and the expectation has been adjusted accordingly. Note that this omission was exposed via a roachtest that uses correctly generated fixtures of SF 100. Fixes: #155834. Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
Contributor
|
Build failed (retrying...): |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we added the fixtures generation of TPCH spec, we forgot a couple of values - one for "priorities" and one for "containers". This commit fixes that omission. In particular, missing priority value made us return 4 rows instead of 5 for Q4, and the expectation has been adjusted accordingly.
Note that this omission was exposed via a roachtest that uses correctly generated fixtures of SF 100.
Fixes: #155834.
Release note: None