publish-artifacts: change GCS latest key prefix for Workload binary#155789
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 22, 2025
Conversation
Member
|
This change is |
rail
approved these changes
Oct 22, 2025
Change previous latest key prefix from 'cockroach' to 'workload' for workload binary to allow for separate lifecycle policies for workload binary objects. Also cleaned up some comments and tests. Informs cockroachdb#154274 Epic: None Release note: None
d6adf42 to
6469695
Compare
Contributor
Author
|
TFTR! bors r=rail |
Contributor
Contributor
Author
|
blathers backport all |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. unexpected status code: 404 Not Found Backport to branch all failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This was referenced Oct 22, 2025
craig bot
pushed a commit
that referenced
this pull request
Oct 23, 2025
155783: sql: several preliminary changes to making tests work with secondary tenants r=yuzefovich a=yuzefovich This PR contains several commits which audit tests in `pkg/sql` directory to ensure the right JobRegistry, codec, LeaseManager, and PGUrl are used. Almost all were pretty mechanical changes. Note that no new tests are enabled with secondary tenants yet - this will be done separately. Epic: CRDB-48945 156002: workload/tpch: add a couple of missed values for fixtures generation r=yuzefovich a=yuzefovich When we added the fixtures generation of TPCH spec, we forgot a couple of values - one for "priorities" and one for "containers". This commit fixes that omission. In particular, missing priority value made us return 4 rows instead of 5 for Q4, and the expectation has been adjusted accordingly. Note that this omission was exposed via a roachtest that uses correctly generated fixtures of SF 100. Fixes: #155834. Release note: None 156008: Revert "publish-artifacts: change GCS latest key prefix for Workload … r=rail a=williamchoe3 Original PR: #155789 Reverting to split into 2 commits for easier backport Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: William Choe <williamchoe3@gmail.com>
This was referenced Nov 3, 2025
This was referenced Nov 4, 2025
rishabh7m
added a commit
to crltest-issue-syncing/cockroach-fork
that referenced
this pull request
Nov 20, 2025
rishabh7m
added a commit
to crltest-issue-syncing/cockroach-fork
that referenced
this pull request
Nov 21, 2025
rishabh7m
added a commit
to crltest-issue-syncing/cockroach-fork
that referenced
this pull request
Nov 21, 2025
rishabh7m
added a commit
to crltest-issue-syncing/cockroach-fork
that referenced
this pull request
Dec 1, 2025
rishabh7m
added a commit
to crltest-issue-syncing/cockroach-fork
that referenced
this pull request
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Informs #154274
In gcs
gs://cockroach-edge-artifacts-prod, changelatestWorkload binary key prefix fromcockroachtoworkloadi.e.
This will allow
latestworkload binary to not be deleted after 30 days so tests can download and use workload binaries from unsupported versions (that no longer have nightlies running against them)Notes:
gs://cockroach-edge-artifacts-prod/cockroach/workload.ee80eab77ca6434f4be7c33c0f6d29dd0b9d07b1is still prefixed withcockroachso these objects will get deleted after 30 days with the current lifecycle policyEdited
PutNonRelease's docstring to remove "redirect" terminology, looks to be from a previous s3 implementation which is not a feature of GCS.Also noticed there's no unit test coverage for non master branches, added 1 release branch test with simple coverage
Also noticed there's a slight difference between mockGCSProvider.PutObject & release.PutObject
Actual
release.PutObjectdoes not modify the key name based on thePutObjectInput.CacheControlfield, but inmockGCSProvider.PutObjectthe"/no-cache"gets appendedI changed the behavior in the mock to match the actual function, and modified the unit tests
FWIW
PutObjectInput.CacheControlis only set toFalsecurrentlyThis PR is a dependency for these roachtest changes: #155397
Also discussed other options like using a new bucket or using the release bucket here: https://cockroachlabs.slack.com/archives/C03SG8QKYRJ/p1760977289072049?thread_ts=1760976858.868889&cid=C03SG8QKYRJ
Decided on this approach for simplicity
For verification, I'm relying on the unit tests. Just assumed this wouldn't work on my local, but if there's a simple way to verify this E2E let me know and i'll do it
Will squash and write a proper commit msg after review, leaving commit separate incase i need to revert anything