roachprod: default --insecure to true#147737
Conversation
|
This change is |
9066382 to
c2de624
Compare
DarrylWong
left a comment
There was a problem hiding this comment.
Change LGTM but I think we still want DRT clusters to be secure right?
They were previously "insecure" because of the missing wrapper, which enables "secure" via a side-effect [1]. @nameisbhaskar fyi [1] cockroach/pkg/cmd/roachprod/cli/util.go Line 109 in 4fbdf6d |
|
My understanding of the drtprod wrapper is that it's mainly used to call the My comment was more so referring to the fact the DRP folks may want to update their scripts to pass in a secure flag when creating a cluster, e.g.: or better yet have some configurable global default for DRT clusters. |
I don't think it does (see |
Yes, we will have to change all the YAML configurations to include this secure flag. |
c2de624 to
77dbbb4
Compare
That wasn't quite right. The YamlProcessor defaults to passing |
As of [1], [2], `roachprod` defaulted to "secure" mode to keep it in one-to-one correspondence with `roachtest`. However, upon further reflection (see an internal thread [3]), "secure mode" adds an unnecessary friction. As of this change, `roachprod` now defaults to "insecure" mode while `roachtest` _continues_ to default to "secure". Further, `drtprod` also continues to default to "secure" mode. [1] cockroachdb#123593 [2] cockroachdb#123826 [3] https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1748888536180379?thread_ts=1724452649.312729&cid=C023S0V4YEB Epic: none Release note: None
77dbbb4 to
8f5f0e6
Compare
|
Smoke Test -- SELECT_PROBABILITY=0.4 |
|
TFTR! bors r=herkolategan,darrylwong,nameisbhaskar |
|
This PR was included in a batch that successfully built, but then failed to merge into master (it was a non-fast-forward update). It will be automatically retried. |
Since cockroachdb#147737, to ease testing for engineering teams, roachprod defaults to insecure clusters. This change has led to security impact for other entities at CRL. This patch brings smart selection of secure vs. insecure cluster depending on the Cloud project the cluster is provisionned in. If the cluster is provisionned in the engineering's ephemeral GCP project, it will default to insecure, while all other configurations will default to secure. In order to achieve that, and because this depends on the cluster's configuration that is not available at the CLI package level, the CLI now keeps track of the user's arguments (--secure, --insecure, default) and passes the information to the roachprod library. Epic: none Release note: None
Since cockroachdb#147737, to ease testing for engineering teams, roachprod defaults to insecure clusters. This change has led to security impact for other entities at CRL. This patch brings smart selection of secure vs. insecure cluster depending on the Cloud project the cluster is provisionned in. If the cluster is provisionned in the engineering's ephemeral GCP project, it will default to insecure, while all other configurations will default to secure. In order to achieve that, and because this depends on the cluster's configuration that is not available at the CLI package level, the CLI now keeps track of the user's arguments (--secure, --insecure, default) and passes the information to the roachprod library. Epic: none Release note: None
Since cockroachdb#147737, to ease testing for engineering teams, roachprod defaults to insecure clusters. This change has led to security impact for other entities at CRL. This patch brings smart selection of secure vs. insecure cluster depending on the Cloud project the cluster is provisionned in. If the cluster is provisionned in the engineering's ephemeral GCP project, it will default to insecure, while all other configurations will default to secure. In order to achieve that, and because this depends on the cluster's configuration that is not available at the CLI package level, the CLI now keeps track of the user's arguments (--secure, --insecure, default) and passes the information to the roachprod library. Epic: none Release note: None
151230: roachprod: default to secure clusters unless GCE cockroach-ephemeral r=herkolategan,srosenberg a=golgeek Since #147737, to ease testing for engineering teams, roachprod defaults to insecure clusters. This change has led to security impact for other entities at CRL. This patch brings smart selection of secure vs. insecure cluster depending on the Cloud project the cluster is provisionned in. If the cluster is provisionned in the engineering's ephemeral GCP project, it will default to insecure, while all other configurations will default to secure. In order to achieve that, and because this depends on the cluster's configuration that is not available at the CLI package level, the CLI now keeps track of the user's arguments (--secure, --insecure, default) and passes the information to the roachprod library. Epic: none Release note: None Co-authored-by: Ludovic Leroux <ludo.leroux@cockroachlabs.com>
As of [1], [2],
roachproddefaulted to"secure" mode to keep it in one-to-one
correspondence with
roachtest. However,upon further reflection (see an internal thread [3]),
"secure mode" adds an unnecessary friction.
As of this change,
roachprodnow defaults to"insecure" mode while
roachtestcontinues todefault to "secure". Further,
drtprodalsocontinues to default to "secure" mode.
[1] #123593
[2] #123826
[3] https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1748888536180379?thread_ts=1724452649.312729&cid=C023S0V4YEB
Epic: none
Release note: None