roachprod: reintroduce --secure flag#123826
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom May 8, 2024
Merged
Conversation
In cockroachdb#123593, we changed roachprod's default when starting clusters: it will now start secure clusters unless the `--insecure` flag is passed (mirroring cockroach's behaviour and flag name). However, this leads to problems when running roachprod commands in commits before and after this change. In this commit, we temporarily reintroduce the `--secure` flag to roachprod to reduce disruptions. Once the new default has existed for a while, we can revert this commit. Epic: none Release note: None
Member
|
This change is |
dt
approved these changes
May 8, 2024
srosenberg
approved these changes
May 8, 2024
Author
|
bors r=dt,srosenberg |
Contributor
srosenberg
added a commit
to srosenberg/cockroach
that referenced
this pull request
Jun 4, 2025
As of [1], [2], `roachprod` defaulted to "secure" mode to keep it in one-to-one correspondence with `roachtest`. However, upon further reflection (see an internal thread [3]), "secure mode" adds an unnecessary friction. As of this change, `roachprod` now defaults to "insecure" mode while `roachtest` _continues_ to default to "secure". We also refactor `drtprod` to reuse the cli wrapper from `roachprod`. This way both binaries have the same behavior wrt `--insecure/--secure`. [1] cockroachdb#123593 [2] cockroachdb#123826 [3] https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1748888536180379?thread_ts=1724452649.312729&cid=C023S0V4YEB Epic: none Release note: None
srosenberg
added a commit
to srosenberg/cockroach
that referenced
this pull request
Jun 26, 2025
As of [1], [2], `roachprod` defaulted to "secure" mode to keep it in one-to-one correspondence with `roachtest`. However, upon further reflection (see an internal thread [3]), "secure mode" adds an unnecessary friction. As of this change, `roachprod` now defaults to "insecure" mode while `roachtest` _continues_ to default to "secure". Further, `drtprod` also continues to default to "secure" mode. [1] cockroachdb#123593 [2] cockroachdb#123826 [3] https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1748888536180379?thread_ts=1724452649.312729&cid=C023S0V4YEB Epic: none Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jun 27, 2025
147737: roachprod: default `--insecure` to `true` r=herkolategan,darrylwong,nameisbhaskar a=srosenberg As of [1], [2], `roachprod` defaulted to "secure" mode to keep it in one-to-one correspondence with `roachtest`. However, upon further reflection (see an internal thread [3]), "secure mode" adds an unnecessary friction. As of this change, `roachprod` now defaults to "insecure" mode while `roachtest` _continues_ to default to "secure". Further, `drtprod` also continues to default to "secure" mode. [1] #123593 [2] #123826 [3] https://cockroachlabs.slack.com/archives/C023S0V4YEB/p1748888536180379?thread_ts=1724452649.312729&cid=C023S0V4YEB Epic: none Release note: None Co-authored-by: Stan Rosenberg <stan.rosenberg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #123593, we changed roachprod's default when starting clusters: it will now start secure clusters unless the
--insecureflag is passed (mirroring cockroach's behaviour and flag name).However, this leads to problems when running roachprod commands in commits before and after this change. In this commit, we temporarily reintroduce the
--secureflag to roachprod to reduce disruptions. Once the new default has existed for a while, we can revert this commit.Epic: none
Release note: None