server,kvtenant: remove usages of gossip.KeyDeprecatedSystemConfig#141849
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 5, 2025
Merged
server,kvtenant: remove usages of gossip.KeyDeprecatedSystemConfig#141849craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
b622788 to
f4b44d6
Compare
Contributor
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/8645e9b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/8645e9bb0a6187cd43c035d6ed28aa6bbe065bfe/bin/pkg_sql_tests benchdiff/8645e9b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/8645e9b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2e66bf7/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2e66bf7c1c1e67eaa11c2994380d467224863cb3/bin/pkg_sql_tests benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=2e66bf7 --new=8645e9b ./pkg/sql/tests⚪ Sysbench [KV, 1node, local, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/8645e9b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/8645e9bb0a6187cd43c035d6ed28aa6bbe065bfe/bin/pkg_sql_tests benchdiff/8645e9b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/8645e9b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2e66bf7/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2e66bf7c1c1e67eaa11c2994380d467224863cb3/bin/pkg_sql_tests benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_read_only$ --old=2e66bf7 --new=8645e9b ./pkg/sql/tests⚪ Sysbench [KV, 1node, local, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/8645e9b/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/8645e9bb0a6187cd43c035d6ed28aa6bbe065bfe/bin/pkg_sql_tests benchdiff/8645e9b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/8645e9b/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2e66bf7/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2e66bf7c1c1e67eaa11c2994380d467224863cb3/bin/pkg_sql_tests benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_write_only$ --old=2e66bf7 --new=8645e9b ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/8645e9bb0a6187cd43c035d6ed28aa6bbe065bfe/13463557395-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/2e66bf7c1c1e67eaa11c2994380d467224863cb3/13463557395-1/\* old/Legend
No regressions detected! built with commit: 8645e9bb0a6187cd43c035d6ed28aa6bbe065bfe |
f4b44d6 to
8645e9b
Compare
8645e9b to
4d4a8fc
Compare
rafiss
commented
Feb 21, 2025
Collaborator
Author
rafiss
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/rpc/auth_tenant.go line 300 at r2 (raw file):
"node:.*", "store:.*", "system-db",
i need to confirm that this is OK to remove. we might need it as long as we still need the gossip.KeyDeprecatedSystemConfig case in GossipSubscription.
This key was only needed in the 21.2/22.2 mixed version state. Removing it and the related machinery allows us to make kvtenant.connector stop implementing SystemConfigProvider. The key should not be reused until it's entirely deleted from the gossip network of existing clusters, so for now the string constant remains as a placeholder. Release note: None
4d4a8fc to
b606fd4
Compare
arulajmani
approved these changes
Mar 5, 2025
Collaborator
arulajmani
left a comment
There was a problem hiding this comment.
Reviewed 9 of 14 files at r2, 10 of 10 files at r3, all commit messages.
Reviewable status:
pkg/rpc/auth_tenant.go line 300 at r2 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
i need to confirm that this is OK to remove. we might need it as long as we still need the
gossip.KeyDeprecatedSystemConfigcase inGossipSubscription.
I don't know for sure off the top of my head, but I'd assume removing this should be fine.
Collaborator
Author
|
tftr! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
craig bot
pushed a commit
that referenced
this pull request
Mar 6, 2025
142375: rpc: add `system-db` back to gossip subscription allowlist r=rafiss a=rafiss This was removed overly-eagerly in b606fd4. We still need it since the KeyDeprecatedSystemConfig key can still be gossipped in a mixed version cluster. Removing it from this allowlist causes noisy warning logs. Epic: None Informs: #141849 Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup after #141815
This key was only needed in the 21.2/22.2 mixed version state.
Removing it and the related machinery allows us to make
kvtenant.connector stop implementing SystemConfigProvider.
The key should not be reused until it's entirely deleted from the gossip
network of existing clusters, so for now the string constant remains as
a placeholder.
fixes #76625
Release note: None