systemconfigwatcher: remove NewWithAdditionalProvider#141815
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Feb 25, 2025
Merged
systemconfigwatcher: remove NewWithAdditionalProvider#141815craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
e7823a4 to
8d14b80
Compare
49de4fe to
59a3b25
Compare
Contributor
⚪ Sysbench [SQL, 3node, oltp_read_write]
Reproducebenchdiff binaries: mkdir -p benchdiff/37b40b8/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/37b40b8f8a387a59b65f2d5fab39d2ebda39df1c/bin/pkg_sql_tests benchdiff/37b40b8/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/37b40b8/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2e66bf7/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2e66bf7c1c1e67eaa11c2994380d467224863cb3/bin/pkg_sql_tests benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=2e66bf7 --new=37b40b8 ./pkg/sql/tests🟡 Sysbench [KV, 1node, local, oltp_read_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/37b40b8/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/37b40b8f8a387a59b65f2d5fab39d2ebda39df1c/bin/pkg_sql_tests benchdiff/37b40b8/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/37b40b8/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2e66bf7/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2e66bf7c1c1e67eaa11c2994380d467224863cb3/bin/pkg_sql_tests benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_read_only$ --old=2e66bf7 --new=37b40b8 ./pkg/sql/tests🟡 Sysbench [KV, 1node, local, oltp_write_only]
Reproducebenchdiff binaries: mkdir -p benchdiff/37b40b8/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/37b40b8f8a387a59b65f2d5fab39d2ebda39df1c/bin/pkg_sql_tests benchdiff/37b40b8/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/37b40b8/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2e66bf7/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2e66bf7c1c1e67eaa11c2994380d467224863cb3/bin/pkg_sql_tests benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2e66bf7/bin/1058449141/cockroachdb_cockroach_pkg_sql_testsbenchdiff command: benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_write_only$ --old=2e66bf7 --new=37b40b8 ./pkg/sql/testsArtifactsdownload: mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/37b40b8f8a387a59b65f2d5fab39d2ebda39df1c/13462853539-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/2e66bf7c1c1e67eaa11c2994380d467224863cb3/13462853539-1/\* old/Legend
No regressions detected! built with commit: 37b40b8f8a387a59b65f2d5fab39d2ebda39df1c |
This was needed in the 21.2-22.1 mixed version state, before tenants had a spanconfig reconciliation job. Now that the job exists, there's no need to pass in an additional provider for tenants. Release note: None
59a3b25 to
37b40b8
Compare
fqazi
approved these changes
Feb 21, 2025
Collaborator
fqazi
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @arulajmani and @dhartunian)
stevendanna
reviewed
Feb 24, 2025
Collaborator
stevendanna
left a comment
There was a problem hiding this comment.
🙏 Thank you for cleaning this up!
Collaborator
Author
|
tftr! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed: |
Collaborator
Author
|
bors retry |
Contributor
craig bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
141849: server,kvtenant: remove usages of gossip.KeyDeprecatedSystemConfig r=rafiss a=rafiss followup after #141815 This key was only needed in the 21.2/22.2 mixed version state. Removing it and the related machinery allows us to make kvtenant.connector stop implementing SystemConfigProvider. The key should not be reused until it's entirely deleted from the gossip network of existing clusters, so for now the string constant remains as a placeholder. fixes #76625 Release note: None Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was needed in the 21.2-22.1 mixed version state, before tenants had a spanconfig reconciliation job. Now that the job exists, there's no need to pass in an additional provider for tenants.
This takes the work in #82329 a bit further.
informs #76625
Release note: None