Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

pkg/storage/store.go, line 2636 at r1 (raw file):

			// exponential backoff.
			if usingPushTxnQueue {
				r.Reset()

Why is this necessary? You already called r.Reset when you set usingPushTxnQueue to true. I think I'm missing something.

Comments from Reviewable

I'm no longer sure about the premise of this change. @spencerkimball pointed out that PushTxn now has the isAlone flag, so the DistSender will split up any batches containing more than one. So if there is anything wrong with this retry loop it's more subtle than multiple pushes in a batch.

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

pkg/storage/store.go, line 2636 at r1 (raw file):

Oops. I was thinking for some reason that this needed to be at the end of the loop, but it doesn't. I'll remove this and the extra variable.

Comments from Reviewable