roachtest: stop using deprecated API in c2c tests#131940
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Oct 4, 2024
Merged
roachtest: stop using deprecated API in c2c tests#131940craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Author
|
Builds on top of #131847. I'll rebase once that one merges. |
This commit stops using the deprecated multitenant functions from `multitenant_utils.` Instead, we use the "official" roachprod API. These tests were the last one still using the old API, so we also remove the `multitenant_utils.go` file entirely in this commit. Fixes: cockroachdb#117673 Release note: None
c98b523 to
4ceb24a
Compare
Author
|
TFTR! bors r=DarrylWong |
Contributor
msbutler
added a commit
to msbutler/cockroach
that referenced
this pull request
Nov 13, 2024
The c2c perf tests histoically have not run a backup schedule on the source. A recent refactor (cockroachdb#131940), lead to backups running on the source. During full backup execution, cpu utilization exceeded 90%, leading to overload and replication lag higher than 2 minutes. This patch removes the backup schedule. At some point, we should run the c2c tests with a backup schedule, but that would require more hardware or more ac pacing work to stabilize the test. These are not priorities now. Fixes cockroachdb#133233 Release note: none
craig bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
134997: crosscluster/logical: commit planner txn early r=dt a=msbutler During large scale testing, we have seen the CreateForTables remote rpc take several seconds or even minutes in LDR planning, and was previously within scope of the planner txn, which could in turn cause txn refresh errors. This patch commits the planner txn earlier in the job hook, before the CreateForTables call, to prevent the planner txn from retrying. Now, the destination side schema validation, locking, and job writing occur in a subsequent txn. Epic: none Release note: none 135071: roachtest: skip running backup schedule on c2c source r=dt a=msbutler The c2c perf tests histoically have not run a backup schedule on the source. A recent refactor (#131940), lead to backups running on the source. During full backup execution, cpu utilization exceeded 90%, leading to overload and replication lag higher than 2 minutes. This patch removes the backup schedule. At some point, we should run the c2c tests with a backup schedule, but that would require more hardware or more ac pacing work to stabilize the test. These are not priorities now. Fixes #133233 Release note: none 135072: roachtest: use unsafe incompatible restore in OR tests r=dt a=msbutler We need to create new fixtures, but that currently takes time. This quiets the test failures. Fixes #134663 Fixes #134659 Release note: none Co-authored-by: Michael Butler <butler@cockroachlabs.com>
blathers-crl bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
The c2c perf tests histoically have not run a backup schedule on the source. A recent refactor (#131940), lead to backups running on the source. During full backup execution, cpu utilization exceeded 90%, leading to overload and replication lag higher than 2 minutes. This patch removes the backup schedule. At some point, we should run the c2c tests with a backup schedule, but that would require more hardware or more ac pacing work to stabilize the test. These are not priorities now. Fixes #133233 Release note: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit stops using the deprecated multitenant functions from
multitenant_utils.Instead, we use the "official" roachprod API.These tests were the last one still using the old API, so we also
remove the
multitenant_utils.gofile entirely in this commit.Fixes: #115867
Release note: None