roachtest: skip running backup schedule on c2c source#135071
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 13, 2024
Merged
roachtest: skip running backup schedule on c2c source#135071craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The c2c perf tests histoically have not run a backup schedule on the source. A recent refactor (cockroachdb#131940), lead to backups running on the source. During full backup execution, cpu utilization exceeded 90%, leading to overload and replication lag higher than 2 minutes. This patch removes the backup schedule. At some point, we should run the c2c tests with a backup schedule, but that would require more hardware or more ac pacing work to stabilize the test. These are not priorities now. Fixes cockroachdb#133233 Release note: none
Member
|
This change is |
dt
approved these changes
Nov 13, 2024
Collaborator
Author
|
TFTR! bors r=dt |
Collaborator
Author
|
TFTR bors r=dt |
Contributor
|
Already running a review |
Contributor
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #133233: branch-release-24.3. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The c2c perf tests histoically have not run a backup schedule on the source. A recent refactor (#131940), lead to backups running on the source. During full backup execution, cpu utilization exceeded 90%, leading to overload and replication lag higher than 2 minutes. This patch removes the backup schedule.
At some point, we should run the c2c tests with a backup schedule, but that would require more hardware or more ac pacing work to stabilize the test. These are not priorities now.
Fixes #133233
Release note: none