add basic http server with health check endpoint#13
Closed
Conversation
Contributor
Author
|
After sleeping on it, I don’t like the magical aspect of the transparent gzip decoding, since the only thing that would change is the test coverage percentage if gzipping responses was ripped out. I will update the test today, but feel free to have at it at the other stuff. |
Contributor
Author
|
Fixed gerrithub issue. Review is now at https://review.gerrithub.io/#/c/1998/ |
This was referenced Apr 12, 2016
soniabhishek
pushed a commit
to soniabhishek/cockroach
that referenced
this pull request
Feb 15, 2017
irfansharif
pushed a commit
that referenced
this pull request
Aug 15, 2020
Bump grpc-gateway version
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this pull request
Jan 20, 2022
Pull in the latest version of `stress` including these changes: ``` 43d99a9 Merge pull request cockroachdb#13 from cockroachdb/bazelsharding 01690a1 stress: add `-bazel` support, support for sharding artifacts ``` Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jan 20, 2022
75169: vendor: pull in latest version of `stress` r=rail a=rickystewart Pull in the latest version of `stress` including these changes: ``` 43d99a9 Merge pull request #13 from cockroachdb/bazelsharding 01690a1 stress: add `-bazel` support, support for sharding artifacts ``` Release note: None 75194: cli: stop ignoring user arg in insecure mode r=otan,knz a=rafiss fixes #74704 Release note (bug fix): The --user argument is no longer ignored when using `cockroach sql` in --insecure mode. 75212: kvserver: de-flake TestReplicateQueueUpAndDownReplicateNonVoters r=irfansharif a=irfansharif Fixes #75135. This test asserted on span configs applying to a scratch range. When stressing, it appeared that some time we were not seeing the scratch range adopt the prescribed number of voters/non-voters. Staring at the test itself, we were only nudging the replication queues for the first node in the three node test. It's possible for the scratch range to have been housed on a node other than the first; this commit makes it so that the test nudges queues on all nodes. For good measure, lets also ensure that the split queues process everything, ditto for the snapshot queues. To repro: dev test pkg/kv/kvserver \ -f TestReplicateQueueUpAndDownReplicateNonVoters \ -v --show-logs --timeout 2m --stress Release note: None 75218: backupccl: disable span configs for full cluster restore jobs test r=irfansharif a=RichardJCai Release note: None Related #75216 75220: kvserver: disable sendWithRangeID call stack r=knz a=tbg Sadly, this on longer embeds the RangeID in the stack trace (likely culprit: Go adopting a register-based calling convention) Instead, you get garbage values that often are obviously garbage, but this may not always be true. We want to avoid being misled, so for now remove the rangeID here and explain when it can come back. See: https://cockroachlabs.slack.com/archives/G01G8LK77DK/p1641478596004700 Release note: None Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com> Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com> Co-authored-by: richardjcai <caioftherichard@gmail.com> Co-authored-by: Tobias Grieger <tobias.b.grieger@gmail.com>
gtr
pushed a commit
to gtr/cockroach
that referenced
this pull request
Jan 24, 2022
Pull in the latest version of `stress` including these changes: ``` 43d99a9 Merge pull request cockroachdb#13 from cockroachdb/bazelsharding 01690a1 stress: add `-bazel` support, support for sharding artifacts ``` Release note: None
pav-kv
pushed a commit
to pav-kv/cockroach
that referenced
this pull request
Mar 5, 2024
annrpom
pushed a commit
to annrpom/cockroach
that referenced
this pull request
Feb 28, 2025
bulksst: add missing sst_info.proto
aerfrei
pushed a commit
to aerfrei/cockroach
that referenced
this pull request
Nov 13, 2025
fix context bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for not using GerritHub. There’s a bug where it won’t let me send out a review because my email is null but I can’t edit my email address :(
I’ve sent a note to them hoping they fix it soon.
In any case, a server for your consideration.