Skip to content

cli: stop ignoring user arg in insecure mode#75194

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-cli-insecure-user-arg
Jan 21, 2022
Merged

cli: stop ignoring user arg in insecure mode#75194
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-cli-insecure-user-arg

Conversation

@rafiss
Copy link
Copy Markdown
Collaborator

@rafiss rafiss commented Jan 20, 2022

fixes #74704

Release note (bug fix): The --user argument is no longer ignored when
using cockroach sql in --insecure mode.

@rafiss rafiss requested a review from a team as a code owner January 20, 2022 04:29
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rafiss rafiss force-pushed the fix-cli-insecure-user-arg branch from 4dda7ea to 95e355c Compare January 20, 2022 06:01
@rafiss rafiss requested review from knz and otan January 20, 2022 06:01
Copy link
Copy Markdown
Contributor

@otan otan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah! nice!

Copy link
Copy Markdown
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, shiny 💯

@rafiss rafiss force-pushed the fix-cli-insecure-user-arg branch from 95e355c to 6baa633 Compare January 20, 2022 16:14
@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Jan 20, 2022

tftrs!

bors r=otan,knz

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 20, 2022

Build failed (retrying...):

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Jan 20, 2022

messed up the rebase

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 20, 2022

Canceled.

Release note (bug fix): The --user argument is no longer ignored when
using `cockroach sql` in --insecure mode.
@rafiss rafiss force-pushed the fix-cli-insecure-user-arg branch from 6baa633 to 9b3efa2 Compare January 20, 2022 20:28
@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Jan 20, 2022

bors r=otan,knz

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 20, 2022

🕐 Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 21, 2022

Build succeeded:

@craig craig bot merged commit 9e22d9d into cockroachdb:master Jan 21, 2022
@rafiss rafiss deleted the fix-cli-insecure-user-arg branch January 21, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: cockroach sql ignores --user flag in --insecure mode

4 participants