Skip to content

roachtest: print issue number after test failure#118914

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
renatolabs:rc/roachtest-include-issue-failure-message
Feb 8, 2024
Merged

roachtest: print issue number after test failure#118914
craig[bot] merged 1 commit intocockroachdb:masterfrom
renatolabs:rc/roachtest-include-issue-failure-message

Conversation

@renatolabs
Copy link
Copy Markdown

This commit updates the GitHub issue poster so that information about
the issue is returned when an issue is created or a comment
added. The roachtest test runner uses this information in the TeamCity
output so that we can easily see the issue corresponding to a test
failure directly in the TC overview page.

Epic: none

Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@renatolabs renatolabs force-pushed the rc/roachtest-include-issue-failure-message branch 2 times, most recently from b2d6ea8 to 86765b5 Compare February 7, 2024 21:22
@renatolabs renatolabs marked this pull request as ready for review February 7, 2024 21:26
@renatolabs renatolabs requested review from a team as code owners February 7, 2024 21:26
@renatolabs renatolabs requested review from herkolategan and srosenberg and removed request for a team February 7, 2024 21:26
@renatolabs
Copy link
Copy Markdown
Author

Quality of life improvement.

Test run on this branch created issue #118920; on the TC overview page, we can see the issue number immediately after the failure message itself:

Screenshot 2024-02-07 at 4 28 04 PM

@renatolabs renatolabs added backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only backport-23.2.x PAST MAINTENANCE SUPPORT: 23.2 patch releases via ER request only labels Feb 8, 2024
@renatolabs renatolabs force-pushed the rc/roachtest-include-issue-failure-message branch from 86765b5 to 12aaa9e Compare February 8, 2024 18:20
This commit updates the GitHub issue poster so that information about
the issue is returned when an issue is created or a comment
added. The roachtest test runner uses this information in the TeamCity
output so that we can easily see the issue corresponding to a test
failure directly in the TC overview page.

Epic: none

Release note: None
@renatolabs renatolabs force-pushed the rc/roachtest-include-issue-failure-message branch from 12aaa9e to fa69450 Compare February 8, 2024 19:16
@renatolabs
Copy link
Copy Markdown
Author

TFTR!

bors r=srosenberg

@craig craig bot merged commit 3671865 into cockroachdb:master Feb 8, 2024
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 8, 2024

Build succeeded:

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Feb 8, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from fa69450 to blathers/backport-release-23.1-118914: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


error creating merge commit from fa69450 to blathers/backport-release-23.2-118914: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

rickystewart added a commit to rickystewart/cockroach that referenced this pull request Feb 9, 2024
This broke with cockroachdb#118914.

Epic: CRDB-8308
Release note: None
craig bot pushed a commit that referenced this pull request Feb 9, 2024
119019: process-bep-file: fix compile error r=rail a=rickystewart

This broke with #118914.

Epic: CRDB-8308
Release note: None

119026: build: add RC branches to release branches r=rickystewart a=rail

Previously, we had logic to distinguish release and non-release branches (like customized builds) in the docker script. The pattern didn't cover cases, where we name the branches by adding the "-rc" suffix.

This PR fixes the release branch pattern.

Epic: none
Release note: None

Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
Co-authored-by: Rail Aliiev <rail@iqchoice.com>
renatolabs pushed a commit to renatolabs/cockroach that referenced this pull request Feb 12, 2024
This broke with cockroachdb#118914.

Epic: CRDB-8308
Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-23.1.x PAST MAINTENANCE SUPPORT: 23.1 patch releases via ER request only backport-23.2.x PAST MAINTENANCE SUPPORT: 23.2 patch releases via ER request only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants