Skip to content

process-bep-file: fix compile error#119019

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:fix-process-bep-file
Feb 9, 2024
Merged

process-bep-file: fix compile error#119019
craig[bot] merged 1 commit intocockroachdb:masterfrom
rickystewart:fix-process-bep-file

Conversation

@rickystewart
Copy link
Copy Markdown
Collaborator

This broke with #118914.

Epic: CRDB-8308
Release note: None

This broke with cockroachdb#118914.

Epic: CRDB-8308
Release note: None
@rickystewart rickystewart requested a review from rail February 9, 2024 17:55
@rickystewart rickystewart requested a review from a team as a code owner February 9, 2024 17:55
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Feb 9, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rickystewart
Copy link
Copy Markdown
Collaborator Author

bors r=rail

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Feb 9, 2024

Build succeeded:

@renatolabs
Copy link
Copy Markdown

Sorry about that! :(

Is it expected that nothing in CI breaks if that package doesn't compile?

@rickystewart
Copy link
Copy Markdown
Collaborator Author

Is it expected that nothing in CI breaks if that package doesn't compile?

I did #119093 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants