Skip to content

release-23.2: s3: disable content pre-upload checksums#115198

Merged
dt merged 1 commit intorelease-23.2from
blathers/backport-release-23.2-115160
Nov 29, 2023
Merged

release-23.2: s3: disable content pre-upload checksums#115198
dt merged 1 commit intorelease-23.2from
blathers/backport-release-23.2-115160

Conversation

@blathers-crl
Copy link
Copy Markdown

@blathers-crl blathers-crl bot commented Nov 28, 2023 •
edited by dt
Loading

Backport 1/1 commits from #115160 on behalf of @dt.

/cc @cockroachdb/release

We send our data over TLS so the integrity of the transport is already checked, and amazon will checksum it server-side before saving it. Additionally, all the blocks in the ssts we're uploading have their own internal checksums, so we really don't gain much from this extra checksumming.

Release note: none.
Epic: none.

Release justification: small fix to reduce impact of backups to s3 on other traffic.

@dt
s3: disable content pre-upload checksums
2acf68b 
We send our data over TLS so the integrity of the transport is already checked,
and amazon will checksum it server-side before saving it. Additionally, all the
blocks in the ssts we're uploading have their own internal checksums, so we really
don't gain much from this extra checksumming.

Release note: none.
Epic: none.
@blathers-crl blathers-crl bot requested a review from a team as a code owner November 28, 2023 19:17
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-115160 branch from 37df486 to 37615b2 Compare November 28, 2023 19:17
@blathers-crl blathers-crl bot requested review from adityamaru and removed request for a team November 28, 2023 19:17
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 28, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-115160 branch from 31424c4 to 2acf68b Compare November 28, 2023 19:17
@blathers-crl blathers-crl bot requested review from dt, nvb and stevendanna November 28, 2023 19:17
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl bot commented Nov 28, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues     or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 28, 2023
@blathers-crl
Copy link
Copy Markdown
Author

blathers-crl bot commented Nov 28, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Nov 28, 2023

This change is Reviewable

@dt dt linked an issue Nov 29, 2023 that may be closed by this pull request
cloud/s3: skip md5 hashing #115189
Closed
@dt dt merged commit 79b7ec6 into release-23.2 Nov 29, 2023
@dt dt deleted the blathers/backport-release-23.2-115160 branch November 29, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevendanna stevendanna stevendanna approved these changes

@adityamaru adityamaru Awaiting requested review from adityamaru adityamaru is a code owner automatically assigned from cockroachdb/disaster-recovery

@dt dt Awaiting requested review from dt

+1 more reviewer

@nvb nvb nvb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dt dt

Labels

backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cloud/s3: skip md5 hashing

4 participants

@cockroach-teamcity @stevendanna @nvb @dt