s3: disable content pre-upload checksums#115160
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Nov 28, 2023
Merged
s3: disable content pre-upload checksums#115160craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
stevendanna
reviewed
Nov 28, 2023
stevendanna
approved these changes
Nov 28, 2023
nvb
approved these changes
Nov 28, 2023
We send our data over TLS so the integrity of the transport is already checked, and amazon will checksum it server-side before saving it. Additionally, all the blocks in the ssts we're uploading have their own internal checksums, so we really don't gain much from this extra checksumming. Release note: none. Epic: none.
Contributor
Author
|
TFTRs! bors r+ |
Contributor
|
Build succeeded: |
This was referenced Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We send our data over TLS so the integrity of the transport is already checked, and amazon will checksum it server-side before saving it. Additionally, all the blocks in the ssts we're uploading have their own internal checksums, so we really don't gain much from this extra checksumming.
Release note: none.
Epic: none.