Skip to content

cloud/s3: skip md5 hashing #115189

@dt

Description

@dt

Part of #115190

We have observed that backups to s3 cause increased tail latencies in foreground traffic, sometimes significantly.

The S3 SDK hashes chunk sized (currently 8mb) blocks both with MD5 and SHA256, for content checksum and signing respectively. It appears that due in large part to golang/go#64417, this causes us to observe long gc pause times and traces show STW pauses overlapping with block hashing.

We can disable the MD5 hashing as it is also done by amazon server side, and thus exists only to verify the upload integrity, but this is already verified by uploading over TLS, while additionally most of the files we upload already have internal or other hashes included in their content, such as SST block checksums.

Jira issue: CRDB-33923

Metadata

Metadata

Assignees

Labels

A-disaster-recoveryC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.O-supportWould prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docsP-0Issues/test failures with a fix SLA of 2 weeksT-disaster-recovery

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions