release-23.1: ccl/multiregionccl: disable transfers in multiregion test#110052
Merged
kvoli merged 2 commits intocockroachdb:release-23.1from Sep 6, 2023
Merged
release-23.1: ccl/multiregionccl: disable transfers in multiregion test#110052kvoli merged 2 commits intocockroachdb:release-23.1from
kvoli merged 2 commits intocockroachdb:release-23.1from
Conversation
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Member
|
This change is |
Previously, `TestMultiRegionDataDriven` allowed kvserver (replicate queue) lease transfers to occur for lease count rebalancing. Load based rebalancing was disabled in an earlier patch cockroachdb#109050, however we saw in interleaving replication changes -- leading to flaky behavior. Bump the `kv.allocator.min_lease_transfer_interval` to 5 minutes, effectively disabling internal lease transfers. Lease transfers which are required for lease preference satisfaction, and manual transfers are still permitted. Fixes: cockroachdb#109215 Release note: None
`TestMultiRegionDataDriven` speeds up replication changes by proactively enqueuing replicas into various queues. This has the benefit of reducing the time taken after zone config changes, however the downside of added overhead. Disable the test under deadlock builds, as the test is slow and susceptible to (legitimate) timing issues on a deadlock build. Informs: cockroachdb#109215 Release note: None
afe873f to
0afcba0
Compare
Contributor
Author
|
|
rafiss
approved these changes
Sep 6, 2023
Contributor
Author
|
TYFTR |
kvoli
added a commit
to kvoli/cockroach
that referenced
this pull request
Sep 6, 2023
Update the cluster setting statement to correctly surround the value duration in quotations.`5m` to `'5m'`. This was fixed in backports to release-23.1 (cockroachdb#110052) and release-22.2 (cockroachdb#110053). However, this was not caught on master due to `TestMultiRegionDataDriven` being skipped. Informs: cockroachdb#98020 Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #109819.
/cc @cockroachdb/release
Previously,
TestMultiRegionDataDrivenallowed kvserver (replicate queue) lease transfers to occur for lease count rebalancing. Load based rebalancing was disabled in an earlier patch #109050, however we saw in interleaving replication changes -- leading to flaky behavior.Bump the
kv.allocator.min_lease_transfer_intervalto 5 minutes, effectively disabling internal lease transfers. Lease transfers which are required for lease preference satisfaction, and manual transfers are still permitted.Fixes: #109215
Release note: None
TestMultiRegionDataDrivenspeeds up replication changes by proactivelyenqueuing replicas into various queues. This has the benefit of reducing
the time taken after zone config changes, however the downside of added
overhead.
Disable the test under deadlock builds, as the test is slow and
susceptible to (legitimate) timing issues on a deadlock build.
Informs: #109215
Release note: None
Release justification: Test only change.