refactor Pagination component#35
Merged
koorosh merged 1 commit intocockroachdb:masterfrom Oct 20, 2020
koorosh:refactor-pagination-component
Merged
refactor Pagination component#35koorosh merged 1 commit intocockroachdb:masterfrom koorosh:refactor-pagination-component
koorosh merged 1 commit intocockroachdb:masterfrom
koorosh:refactor-pagination-component
Conversation
Member
|
This change is |
nathanstilwell
suggested changes
Oct 13, 2020
Contributor
nathanstilwell
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @koorosh)
src/pagination/pagination.module.scss, line 1 at r1 (raw file):
@import '../core/index.module';
I think we prefer double quotes for imports
Previously, Pagination component has been created but not used as a single version for pagination. In addition, Ant design components were imported right into page views with duplicated styles and it brought us into situation with multiple versions of almost identical functionality. This change is a step forward to remove duplicated components and use single version of pagination component. Along with this, `Pagination` component is refactored with respect to latest designs. `ResultsPerPageLabel` component is extracted as a standalone component which displays number of results per paginated view. This functionality is used in several places so it's a good time to refactor it as well.
Contributor
Author
Done |
nathanstilwell
approved these changes
Oct 20, 2020
Contributor
nathanstilwell
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Oct 22, 2020
55499: ui: update styles for session details page r=koorosh a=koorosh resolves #54513 depends on cockroachdb/admin-ui-components#31 depends on cockroachdb/admin-ui-components#34 depends on cockroachdb/admin-ui-components#35 Current fix is quite complex and touches a lot of places because most of the issues with styles were common for all pages (Statements, Jobs, Node Overview). Also many style duplicates required to get rid of duplicates and unify single version of proper components to use across entire app. It's easier to review this PR per commit. Each commit describes in details what changes were made and their purpose.   Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant to issue cockroachdb/cockroach#54513 (3rd item)
Previously, Pagination component has been created but not used
as a single version for pagination. In addition, Ant design components
were imported right into page views with duplicated styles and it brought
us into situation with multiple versions of almost identical functionality.
This change is a step forward to remove duplicated components and use single
version of pagination component. Along with this,
Paginationcomponent isrefactored with respect to latest designs.
ResultsPerPageLabelcomponent is extracted as a standalone component whichdisplays number of results per paginated view. This functionality is used in
several places so it's a good time to refactor it as well.