fix styles for cells with links in sortable table#34
Merged
koorosh merged 1 commit intocockroachdb:masterfrom Oct 15, 2020
koorosh:ui-sortable-table-styles-fix
Merged
fix styles for cells with links in sortable table#34koorosh merged 1 commit intocockroachdb:masterfrom koorosh:ui-sortable-table-styles-fix
koorosh merged 1 commit intocockroachdb:masterfrom
koorosh:ui-sortable-table-styles-fix
Conversation
Member
|
This change is |
nathanstilwell
approved these changes
Oct 13, 2020
Contributor
nathanstilwell
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dhartunian and @elkmaster)
Regression of styles in sortable table and consequently in statements table was introduced during statements page extraction. Links in table has to be by default with black colored and change color to blue on hover. Also font-size for text cells was incorrect, 12px instead of required 14px. Current fix applies these styles on base elements with some cleanup for styles.
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Oct 22, 2020
55499: ui: update styles for session details page r=koorosh a=koorosh resolves #54513 depends on cockroachdb/admin-ui-components#31 depends on cockroachdb/admin-ui-components#34 depends on cockroachdb/admin-ui-components#35 Current fix is quite complex and touches a lot of places because most of the issues with styles were common for all pages (Statements, Jobs, Node Overview). Also many style duplicates required to get rid of duplicates and unify single version of proper components to use across entire app. It's easier to review this PR per commit. Each commit describes in details what changes were made and their purpose.   Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression of styles in sortable table and consequently in
statements table was introduced during statements page extraction.
Links in table has to be by default with black colored and change
color to blue on hover. Also font-size for text cells was incorrect,
12px instead of required 14px.
Current fix applies these styles
on base elements with some cleanup
for styles.
Relevant to issue cockroachdb/cockroach#54513