Skip to content

add email addresses to users in keycloak#299

Merged
nimakaviani merged 1 commit intocnoe-io:mainfrom
omrishiv:add-email-to-users
Jun 14, 2024
Merged

add email addresses to users in keycloak#299
nimakaviani merged 1 commit intocnoe-io:mainfrom
omrishiv:add-email-to-users

Conversation

@omrishiv
Copy link
Copy Markdown
Contributor

In preparation for adding the observability stack, Grafana requires an email address for SSO users.

Signed-off-by: omrishiv <327609+omrishiv@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit 586a519 into cnoe-io:main Jun 14, 2024
@nabuskey
Copy link
Copy Markdown
Collaborator

Shouldn't have merged this. This dir is to be deleted.

#280

Update here instead. https://github.com/cnoe-io/stacks

@nimakaviani
Copy link
Copy Markdown
Contributor

ah yes. @omrishiv, mind updating it in the stacks repo?

@omrishiv
Copy link
Copy Markdown
Contributor Author

Argh! yea, I see it. Sorry, I'll open one there

@omrishiv omrishiv deleted the add-email-to-users branch June 14, 2024 18:49
nimakaviani added a commit that referenced this pull request Jun 17, 2024
nimakaviani added a commit that referenced this pull request Jun 17, 2024
This reverts commit 586a519.

Signed-off-by: Nima Kaviani <nkaviani@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants