Skip to content

remove examples directory#280

Merged
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:rm-examples
Jun 17, 2024
Merged

remove examples directory#280
nimakaviani merged 1 commit intocnoe-io:mainfrom
nabuskey:rm-examples

Conversation

@nabuskey
Copy link
Copy Markdown
Collaborator

@nabuskey nabuskey commented Jun 4, 2024

This PR removes the examples directory and references the stacks repository instead.

Need:

closes: #279

@nimakaviani
Copy link
Copy Markdown
Contributor

I love PRs like this. will need to take some time to read the README and also update the CNOE website accordingly before merging this in. but hopefully before the end of the week.

@nabuskey
Copy link
Copy Markdown
Collaborator Author

nabuskey commented Jun 5, 2024

Yeah thinking about it, we need to update the stacks readme too. Let's wait a bit.

Signed-off-by: Manabu McCloskey <manabu.mccloskey@gmail.com>
Copy link
Copy Markdown
Contributor

@nimakaviani nimakaviani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nimakaviani nimakaviani merged commit e8e2319 into cnoe-io:main Jun 17, 2024
@nabuskey nabuskey deleted the rm-examples branch June 17, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup - remove the examples directory and fix docs

2 participants