Skip to content

chore: Golangci: remove deprecated plugins (and decorder)#64

Merged
erezrokah merged 1 commit intomainfrom
update-golangci
Sep 7, 2022
Merged

chore: Golangci: remove deprecated plugins (and decorder)#64
erezrokah merged 1 commit intomainfrom
update-golangci

Conversation

@hermanschaaf
Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf commented Sep 7, 2022

Some plugins are no longer supported and can be removed. I am also proposing we remove decorder: until it has the ability to automatically fix the issues it reports, we are wasting our time for (imo) little gain.

As for the deprecated plugins, here is the message from latest golanci-lint:

WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.
WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter.  Replaced by unused.

@hermanschaaf
golangci: remove deprecated plugins (and decorder)
d1bfa52 
Some plugins are no longer supported and can be removed. I am also proposing we remove decorder: until it has the ability to automatically fix the issues it reports, we are wasting our time for (imo) little gain.
@hermanschaaf hermanschaaf requested review from erezrokah and removed request for yevgenypats September 7, 2022 08:26
@hermanschaaf hermanschaaf changed the title golangci: remove deprecated plugins (and decorder) chore: Golangci: remove deprecated plugins (and decorder) Sep 7, 2022
@erezrokah
Copy link
Copy Markdown
Member

erezrokah commented Sep 7, 2022

Nice 🚀 For decorder if we don't enforce it via a linter I suggest we don't enforce it in code reviews either (that was the reason I added it)

@erezrokah erezrokah merged commit e3c3458 into main Sep 7, 2022
@erezrokah erezrokah deleted the update-golangci branch September 7, 2022 08:50
@hermanschaaf hermanschaaf mentioned this pull request Sep 7, 2022
Merged
kodiakhq bot pushed a commit to cloudquery/cloudquery that referenced this pull request Sep 7, 2022
@hermanschaaf
chore: Remove deprecated linters (and dec-order) (#1765)
16d5be5 
Similar to cloudquery/plugin-sdk#64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disq disq disq approved these changes

@erezrokah erezrokah erezrokah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hermanschaaf @erezrokah @disq