Skip to content

chore: Remove deprecated linters (and dec-order)#1765

Merged
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom
hermanschaaf:remove-linters
Sep 7, 2022
Merged

chore: Remove deprecated linters (and dec-order)#1765
kodiakhq[bot] merged 4 commits intocloudquery:mainfrom
hermanschaaf:remove-linters

Conversation

@hermanschaaf
Copy link
Copy Markdown
Contributor

@hermanschaaf hermanschaaf commented Sep 7, 2022

This also upgrades to the latest version of golangci-lint (v1.49.0)
@hermanschaaf hermanschaaf requested a review from a team September 7, 2022 11:52
@erezrokah
Copy link
Copy Markdown
Member

I think we need to update to go@1.19 to upgrade the linter #1553 (comment) as the latest version of the linter formats code using go@1.19 which is a bit different.

You can trigger both updates via #760
image

Copy link
Copy Markdown
Member

@erezrokah erezrokah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but I'd keep the current version of the linter per my comment and also merge with main to get latest fixes from 7a83a65

@hermanschaaf
Copy link
Copy Markdown
Contributor Author

@erezrokah Ah okay, thanks! I'll revert the linter upgrade part 👍

@hermanschaaf hermanschaaf changed the title Remove deprecated linters (and dec-order) chore: Remove deprecated linters (and dec-order) Sep 7, 2022
@hermanschaaf hermanschaaf added the automerge Automatically merge once required checks pass label Sep 7, 2022
@kodiakhq kodiakhq bot merged commit 16d5be5 into cloudquery:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants