fix(metrics): Fix metrics propagation for destination plugins with managed write mode#585
Closed
candiduslynx wants to merge 1 commit intomainfrom
Closed
fix(metrics): Fix metrics propagation for destination plugins with managed write mode#585candiduslynx wants to merge 1 commit intomainfrom
candiduslynx wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
this PR is following in the steps of #583 |
⏱️ Benchmark resultsComparing with c196a74
|
hermanschaaf
suggested changes
Jan 9, 2023
Contributor
hermanschaaf
left a comment
There was a problem hiding this comment.
Looks good, just left a few comments. It would also be good to add a test that ensures the metrics behavior stays fixed.
c33119b to
4729f2f
Compare
cd7dc21 to
6d71c67
Compare
hermanschaaf
approved these changes
Jan 10, 2023
e7c2d14 to
38448ea
Compare
yevgenypats
suggested changes
Jan 11, 2023
yevgenypats
reviewed
Jan 11, 2023
Contributor
|
Prob worth a live chat as I don't think I quite understand what this solves |
38448ea to
c727fda
Compare
Contributor
Author
|
@yevgenypats I've updated the metrics code. Now we use sync.Uint64 to store locally & return the |
Contributor
Author
|
related to cloudquery/cloudquery#6761 |
c727fda to
50bcb13
Compare
kodiakhq bot
pushed a commit
to cloudquery/cloudquery
that referenced
this pull request
Jan 18, 2023
Implements #6145. Depends on: * cloudquery/plugin-sdk/pull/585 * cloudquery/plugin-sdk/pull/606
Contributor
|
Closing as I didn't understand the fix and I'll prob just fix the metrics later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored destination plugin metrics: