fix(metrics): Fix metrics propagation for destination plugins with managed write mode#583
Closed
candiduslynx wants to merge 0 commit intomainfrom
Closed
fix(metrics): Fix metrics propagation for destination plugins with managed write mode#583candiduslynx wants to merge 0 commit intomainfrom
candiduslynx wants to merge 0 commit intomainfrom
Conversation
⏱️ Benchmark resultsComparing with 7c15d9a
|
erezrokah
requested changes
Jan 9, 2023
Member
erezrokah
left a comment
There was a problem hiding this comment.
Thanks for the PR @candiduslynx, can we separate the refactor from the bug fix?
It's hard to understand the fix itself.
Also I think with this fix, we're losing the granularity of the error messages (e.g. which flush failed)
f4d14d4 to
b693034
Compare
Contributor
Author
|
refactor part was similarly implemented in #582. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.