Merged
Conversation
erezrokah
approved these changes
Nov 10, 2022
disq
reviewed
Nov 10, 2022
disq
approved these changes
Nov 10, 2022
Member
disq
left a comment
There was a problem hiding this comment.
Good call with -race, LGTM with one nit.
yevgenypats
approved these changes
Nov 10, 2022
hermanschaaf
pushed a commit
that referenced
this pull request
Nov 10, 2022
🤖 I have created a release *beep* *boop* --- ## [1.3.2](v1.3.1...v1.3.2) (2022-11-10) ### Bug Fixes * Add -race when running tests ([#388](#388)) ([3da08bb](3da08bb)) * Close zip archive when we're done with it ([#391](#391)) ([1c4a877](1c4a877)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
-raceflag togo test, so we can detect data races in the tests. There were two instances that I had to fix for this to succeed (not really a bug: just the test accessing a variable that another goroutine is writing to) - for now fixed using a lock around the variable.Some other test were failing when I ran
go test -race -count 3 ./...because of global variables being modified in the test. This also fixes this issue.The only real functional change is that we now only add a
_cq_idcolumn if it is not already present.