Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.3.1
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.3.2
Choose a head ref
  • 3 commits
  • 11 files changed
  • 2 contributors

Commits on Nov 10, 2022

  1. fix: Close zip archive when we're done with it (#391) 

    I suspect this will help fix #354
    @hermanschaaf
    hermanschaaf authored Nov 10, 2022
    Configuration menu
    Copy the full SHA
    1c4a877 View commit details
    Browse the repository at this point in the history

  2. fix: Add -race when running tests (#388) 

    This adds the `-race` flag to `go test`, so we can detect data races in the tests. There were two instances that I had to fix for this to succeed (not really a bug: just the test accessing a variable that another goroutine is writing to) - for now fixed using a lock around the variable.

Some other test were failing when I ran `go test -race -count 3 ./...` because of global variables being modified in the test. This also fixes this issue.  

The only real functional change is that we now only add a `_cq_id` column if it is not already present.
    @hermanschaaf
    hermanschaaf authored Nov 10, 2022
    Configuration menu
    Copy the full SHA
    3da08bb View commit details
    Browse the repository at this point in the history

  3. chore(main): Release v1.3.2 (#393) 

    🤖 I have created a release *beep* *boop*
---


##
[1.3.2](v1.3.1...v1.3.2)
(2022-11-10)


### Bug Fixes

* Add -race when running tests
([#388](#388))
([3da08bb](3da08bb))
* Close zip archive when we're done with it
([#391](#391))
([1c4a877](1c4a877))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
    @cq-bot
    cq-bot authored Nov 10, 2022
    Configuration menu
    Copy the full SHA
    01b0c96 View commit details
    Browse the repository at this point in the history
Loading