fix: Revert "chore: Start SDK semantic versioning from v1"#366
Merged
kodiakhq[bot] merged 1 commit intomainfrom Nov 7, 2022
Merged
fix: Revert "chore: Start SDK semantic versioning from v1"#366kodiakhq[bot] merged 1 commit intomainfrom
kodiakhq[bot] merged 1 commit intomainfrom
Conversation
This reverts commit 40041c8.
erezrokah
approved these changes
Nov 7, 2022
Member
|
Or just merge this as |
yevgenypats
approved these changes
Nov 7, 2022
Contributor
|
What are the v2 tags? I dont see any. Regarding deleting the previous ones. I think no need as no one will import them and we just bump a minor version to v1.0.2 and all should work. starting v2 in any case we need to have |
Member
💯 Just revised my comment |
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.2](v1.0.1...v1.0.2) (2022-11-07) ### Bug Fixes * Revert "chore: Start SDK semantic versioning from v1" ([#366](#366)) ([c66be4b](c66be4b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #362
I think the change to use v1 is invalid, as Go expects versioning to be used only from v2 onwards. When importing it in
cloudquery/cloudquery, I'm getting this error: