chore: Start SDK semantic versioning from v1#362
Merged
Conversation
22db6cb to
6d4d322
Compare
hermanschaaf
approved these changes
Nov 7, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
🤖 I have created a release *beep* *boop* --- ## [1.0.0](v0.13.23...v1.0.0) (2022-11-07) ### Bug Fixes * Dont use reflection in reverse transformer ([#360](#360)) ([9c85c1a](9c85c1a)) ### Miscellaneous Chores * Start SDK semantic versioning from v1 ([#362](#362)) ([40041c8](40041c8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
hermanschaaf
added a commit
that referenced
this pull request
Nov 7, 2022
This reverts commit 40041c8.
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
Reverts #362 I think the change to use v1 is invalid, as Go expects versioning to be used only from v2 onwards. When importing it in `cloudquery/cloudquery`, I'm getting this error: ``` require github.com/cloudquery/plugin-sdk/v1: version "v1.0.1" invalid: malformed module path "github.com/cloudquery/plugin-sdk/v1" ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't really break anything but it starts versioning the sdk appropriately so it will be easier to update all plugins once we change to
v2because this change will require us to update everything to/v1(just search and replace, as no functionally/API changes )