Skip to content

fix(tests): Parallel plugin testing, remove old faker#292

Merged
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
disq:fix/parallel_plugin_testing
Oct 14, 2022
Merged

fix(tests): Parallel plugin testing, remove old faker#292
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
disq:fix/parallel_plugin_testing

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Oct 13, 2022

Something like cloudquery/cloudquery#2788 but in the sdk.

@disq disq requested a review from yevgenypats as a code owner October 13, 2022 17:51
@github-actions github-actions bot added the fix label Oct 13, 2022
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented on the interface

@disq
Copy link
Copy Markdown
Member Author

disq commented Oct 14, 2022

commented on the interface

done, had to be slightly different than your normal goish opts in implementation.

@disq disq requested a review from yevgenypats October 14, 2022 07:37
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit.

@kodiakhq kodiakhq bot merged commit 48f953a into cloudquery:main Oct 14, 2022
@disq disq deleted the fix/parallel_plugin_testing branch October 14, 2022 08:22
kodiakhq bot pushed a commit that referenced this pull request Oct 14, 2022
🤖 I have created a release *beep* *boop*
---


## [0.13.8](v0.13.7...v0.13.8) (2022-10-14)


### Features

* Support application level protocol message. ([#294](#294)) ([3e1492b](3e1492b))


### Bug Fixes

* **tests:** Parallel plugin testing, remove old faker ([#292](#292)) ([48f953a](48f953a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants