Skip to content

chore(tests): Try parallel testing#2788

Closed
disq wants to merge 1 commit intocloudquery:mainfrom
disq:chore/try-parallel-testing
Closed

chore(tests): Try parallel testing#2788
disq wants to merge 1 commit intocloudquery:mainfrom
disq:chore/try-parallel-testing

Conversation

@disq
Copy link
Copy Markdown
Member

@disq disq commented Oct 13, 2022

Try parallel testing on all tests using mock test helpers.

@disq disq requested a review from a team October 13, 2022 14:17
@erezrokah
Copy link
Copy Markdown
Member

erezrokah commented Oct 13, 2022

For AWS tests changed from 2m 6s to 1m 48s:
https://github.com/cloudquery/cloudquery/actions/runs/3243124043/jobs/5317379722
https://github.com/cloudquery/cloudquery/actions/runs/3243092646/jobs/5317306478

But that's only one run

@yevgenypats
Copy link
Copy Markdown
Contributor

yevgenypats commented Oct 13, 2022

For AWS tests changed from 2m 6s to 1m 48s: https://github.com/cloudquery/cloudquery/actions/runs/3243124043/jobs/5317379722 https://github.com/cloudquery/cloudquery/actions/runs/3243092646/jobs/5317306478

But that's only one run

@erezrokah maybe increasing GOMAXPROCS to 4 or 8 will help ?

yevgenypats
yevgenypats suggested changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should into the SDK TestSourcePluginSync

@disq
Copy link
Copy Markdown
Member Author

disq commented Oct 13, 2022

TestSourcePluginSync

but that method doesn't take an option, to override (disable) parallel testing?

@disq disq mentioned this pull request Oct 13, 2022
Merged
@yevgenypats
Copy link
Copy Markdown
Contributor

yevgenypats commented Oct 13, 2022

TestSourcePluginSync

but that method doesn't take an option, to override (disable) parallel testing?

I think then it would be great case to introduce option and make it default enabled :)

@disq disq closed this Oct 14, 2022
@disq disq deleted the chore/try-parallel-testing branch October 14, 2022 07:37
kodiakhq bot pushed a commit to cloudquery/plugin-sdk that referenced this pull request Oct 14, 2022
@disq
fix(tests): Parallel plugin testing, remove old faker (#292)
48f953a 
Something like cloudquery/cloudquery#2788 but in the sdk.
@erezrokah
Copy link
Copy Markdown
Member

erezrokah commented Oct 16, 2022

@erezrokah maybe increasing GOMAXPROCS to 4 or 8 will help ?

Maybe GitHub machines are not strong enough to take advantage. Regardless this is probably good for local dev machiens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erezrokah erezrokah erezrokah approved these changes

@hermanschaaf hermanschaaf Awaiting requested review from hermanschaaf

+1 more reviewer

@yevgenypats yevgenypats yevgenypats requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@disq @erezrokah @yevgenypats @cq-bot