fix: Plugin connection using Unix Domain Socket fixed for windows#246
Merged
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom Oct 5, 2022
Merged
fix: Plugin connection using Unix Domain Socket fixed for windows#246kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
kodiakhq[bot] merged 3 commits intocloudquery:mainfrom
Conversation
amanenk
commented
Oct 4, 2022
yevgenypats
approved these changes
Oct 5, 2022
Contributor
yevgenypats
left a comment
There was a problem hiding this comment.
Good catch. Looks good. I'll let @hermanschaaf also take a look to make sure I didn't miss something.
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [0.12.6](v0.12.5...v0.12.6) (2022-10-05) ### Bug Fixes * Plugin connection using Unix Domain Socket fixed for windows ([#246](#246)) ([9e30c60](9e30c60)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Member
|
Thank you so much for this fix @amanenk, finally cloudquery/cloudquery#2204 (comment) is unblocked 👍 It would have taken be quite a bit of time to set up a Windows VM to reproduce this 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
closes #245
grpc.Dialdoes not work with "unix://" prefix on windows. protocol should be set in dialer to make it workUse the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)