Skip to content

chore(ci): Run CLI tests on Mac and Windows#2204

Merged
kodiakhq[bot] merged 8 commits intocloudquery:mainfrom
erezrokah:chore/cli_cross_env
Oct 9, 2022
Merged

chore(ci): Run CLI tests on Mac and Windows#2204
kodiakhq[bot] merged 8 commits intocloudquery:mainfrom
erezrokah:chore/cli_cross_env

Conversation

@erezrokah
Copy link
Copy Markdown
Member

Summary

Fixes #1803

@erezrokah erezrokah force-pushed the chore/cli_cross_env branch from 2e9ead4 to 6ae1c8c Compare October 2, 2022 14:14
@erezrokah erezrokah changed the title chore(ci): Run CLI tests on Mac and Windows too chore(ci): Run CLI tests on Mac and Windows Oct 2, 2022
@erezrokah erezrokah added the automerge Automatically merge once required checks pass label Oct 2, 2022
@erezrokah
Copy link
Copy Markdown
Member Author

Tests are failing due to #2206

yevgenypats added a commit to cloudquery/plugin-sdk that referenced this pull request Oct 3, 2022
#### Summary

<!-- 🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉 -->

Hard to test this as we need to release a new SDK, update it in the CLI
and then test again via
cloudquery/cloudquery#2204.

Similar to the fix in cloudquery/cloudquery#1894


Co-authored-by: Yevgeny Pats <yev.pats@gmail.com>
@erezrokah
Copy link
Copy Markdown
Member Author

erezrokah commented Oct 3, 2022

Still fails on Windows with a different error after the SDK update 😄

@erezrokah
Copy link
Copy Markdown
Member Author

For some reason testing on Windows hangs now, so can't be sure it's working.

@kodiakhq kodiakhq bot merged commit 11dbe2f into cloudquery:main Oct 9, 2022
@erezrokah erezrokah deleted the chore/cli_cross_env branch October 9, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Automatically merge once required checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: Add tests on multiple OS

2 participants