fix: Use correct path for Windows zip#223
Conversation
yevgenypats
left a comment
There was a problem hiding this comment.
does .exe really needed on windows? Im not sure that the case especially for something that is not user faceing and it will make the code more complex because path will change depending on OS
|
Either we fix this in the SDK, or we change our build configuration (if possible). We can do some tests to see if we can drop it, but maybe we can merge the fix as currently the CLI is broken on Windows? |
🤖 I have created a release *beep* *boop* --- ## [0.11.5](v0.11.4...v0.11.5) (2022-10-03) ### Bug Fixes * Create doc directory if doesn't exist ([#220](#220)) ([067534d](067534d)) * **deps:** Update golang.org/x/exp digest to 540bb73 ([#212](#212)) ([2e3dae3](2e3dae3)) * **deps:** Update golang.org/x/sync digest to 8fcdb60 ([#213](#213)) ([7d7d85f](7d7d85f)) * Remove redundant error print ([#226](#226)) ([9927ede](9927ede)) * Remove unused docs template function ([#221](#221)) ([f65f023](f65f023)) * Use correct path for Windows zip ([#223](#223)) ([960f650](960f650)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Summary
Hard to test this as we need to release a new SDK, update it in the CLI and then test again via cloudquery/cloudquery#2204.
Similar to the fix in cloudquery/cloudquery#1894
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊golangci-lint run🚨 (install golangci-lint here)