Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.7.0-rc1
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.7.1-rc1
Choose a head ref
  • 8 commits
  • 19 files changed
  • 5 contributors

Commits on Jul 4, 2023

  1. fix(configtype): Add Equal() method to Duration (#1059) 

    `cmp.Diff` doesn't like it otherwise.
    @disq
    disq authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    57c7bc2 View commit details
    Browse the repository at this point in the history

  2. fix(testdata): Add missing column types (#1061) 

    Just add the missing ones. Supercedes #1057
    @disq
    disq authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f5d01c9 View commit details
    Browse the repository at this point in the history

  3. fix: Check record data in tests (#1062) 

    This adds back assertions on the record data in destination writer tests. I'm not sure if we also need to handle ordering somehow here, but I think we can follow up with a fix for that if necessary.
    @hermanschaaf
    hermanschaaf authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    f13e4cc View commit details
    Browse the repository at this point in the history

  4. fix: Conversion and test fixes (#1064) 

    Some fixes to the scalar and testing code:
- use `AppendTime` in `AppendToBuilder` to take different time units
into account
- base64 decode binary-encoded JSON strings when the type calls for it
in struct `Set()`, otherwise the binary data gets interpreted as a
string and the results are incorrect
- exclude the JSON type from list tests, we didn't support that before
and don't need to introduce it now
    @hermanschaaf
    hermanschaaf authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    36b65cb View commit details
    Browse the repository at this point in the history

  5. refactor(ticker): Don't reset manually (#1058) 

    Follow-up for #1056
    @candiduslynx
    candiduslynx authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    646d451 View commit details
    Browse the repository at this point in the history

  6. fix: Add AddCqIDs helper function (#1065)

    @yevgenypats
    yevgenypats authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    911762d View commit details
    Browse the repository at this point in the history

  7. fix: Fix test assertions for records (#1066) 

    We should check the first record higher up, because after the migration it will have an additional column and is therefore bound to differ from the original record.
    @hermanschaaf
    hermanschaaf authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    a9bd88f View commit details
    Browse the repository at this point in the history

  8. chore(main): Release v4.7.1-rc1 (#1060) 

    🤖 I have created a release *beep* *boop*
---


## [4.7.1-rc1](v4.7.0-rc1...v4.7.1-rc1) (2023-07-04)


### Bug Fixes

* Add AddCqIDs helper function ([#1065](#1065)) ([911762d](911762d))
* Check record data in tests ([#1062](#1062)) ([f13e4cc](f13e4cc))
* **configtype:** Add `Equal()` method to `Duration` ([#1059](#1059)) ([57c7bc2](57c7bc2))
* Conversion and test fixes ([#1064](#1064)) ([36b65cb](36b65cb))
* Fix test assertions for records ([#1066](#1066)) ([a9bd88f](a9bd88f))
* **testdata:** Add missing column types ([#1061](#1061)) ([f5d01c9](f5d01c9))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
    @cq-bot
    cq-bot authored Jul 4, 2023
    Configuration menu
    Copy the full SHA
    006459f View commit details
    Browse the repository at this point in the history
Loading