fix(testdata): Bring back all Arrow types#1057
fix(testdata): Bring back all Arrow types#1057disq wants to merge 1 commit intocloudquery:mainfrom disq:fix/bring-back-all-test-types
Conversation
|
What is the actual difference in terms of type coverage? Can't we just add the missing ones (if any?) |
If we add anything manually it would have to be maintained if new types show up in Arrow. Some types (some intervals and some "simples" like |
I think that's okay (saying this as the person who originally wrote the code looping over Arrow types); we don't have to support new Arrow types immediately after their release, and we get simpler code if we don't loop over the types. I would vote to add the couple of missing types for now. |
Just add the missing ones. Supercedes #1057
Refer to the comment here for explanation: cloudquery/cloudquery#11724 (comment)
diff from
v3.10.6: