Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.5.0
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.5.1
Choose a head ref
  • 4 commits
  • 9 files changed
  • 2 contributors

Commits on Aug 15, 2023

  1. fix(deps): Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.0 (

    #1145)
    
    This PR contains the following updates:
    
    | Package | Type | Update | Change |
    |---|---|---|---|
    | [github.com/cloudquery/plugin-sdk/v4](https://togithub.com/cloudquery/plugin-sdk) | require | minor | `v4.4.0` -> `v4.5.0` |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>cloudquery/plugin-sdk (github.com/cloudquery/plugin-sdk/v4)</summary>
    
    ### [`v4.5.0`](https://togithub.com/cloudquery/plugin-sdk/releases/tag/v4.5.0)
    
    [Compare Source](https://togithub.com/cloudquery/plugin-sdk/compare/v4.4.0...v4.5.0)
    
    ##### Features
    
    -   Add publish command ([#&#8203;1143](https://togithub.com/cloudquery/plugin-sdk/issues/1143)) ([fdd44d5](https://togithub.com/cloudquery/plugin-sdk/commit/fdd44d5d3a9ce12d59e168ea691a343f6f219694))
    
    ##### Bug Fixes
    
    -   **deps:** Update github.com/cloudquery/arrow/go/v13 digest to [`e9683e1`](https://togithub.com/cloudquery/plugin-sdk/commit/e9683e1) ([#&#8203;1144](https://togithub.com/cloudquery/plugin-sdk/issues/1144)) ([763c549](https://togithub.com/cloudquery/plugin-sdk/commit/763c549a783f69d7adfb7291534d3d2b25d697e5))
    -   Scalar timestamp parsing ([#&#8203;1109](https://togithub.com/cloudquery/plugin-sdk/issues/1109)) ([c15b214](https://togithub.com/cloudquery/plugin-sdk/commit/c15b214a346fa8a89c929858c2623317e7048211))
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40NC4wIiwidXBkYXRlZEluVmVyIjoiMzYuNDQuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
    cq-bot authored Aug 15, 2023
    1 Configuration menu
    Copy the full SHA
    70d12e4 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. fix(deps): Update module github.com/cloudquery/plugin-pb-go to v1.9.3 (

    …#1149)
    
    This PR contains the following updates:
    
    | Package | Type | Update | Change |
    |---|---|---|---|
    | [github.com/cloudquery/plugin-pb-go](https://togithub.com/cloudquery/plugin-pb-go) | require | patch | `v1.9.2` -> `v1.9.3` |
    | [github.com/cloudquery/plugin-pb-go](https://togithub.com/cloudquery/plugin-pb-go) | indirect | patch | `v1.9.2` -> `v1.9.3` |
    
    ---
    
    ### Release Notes
    
    <details>
    <summary>cloudquery/plugin-pb-go (github.com/cloudquery/plugin-pb-go)</summary>
    
    ### [`v1.9.3`](https://togithub.com/cloudquery/plugin-pb-go/releases/tag/v1.9.3)
    
    [Compare Source](https://togithub.com/cloudquery/plugin-pb-go/compare/v1.9.2...v1.9.3)
    
    ##### Bug Fixes
    
    -   Create docker container with Tty true ([#&#8203;87](https://togithub.com/cloudquery/plugin-pb-go/issues/87)) ([4c70f9a](https://togithub.com/cloudquery/plugin-pb-go/commit/4c70f9ad6979b5eae4b47dff774b4ffeb92d1246))
    
    </details>
    
    ---
    
    ### Configuration
    
    📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
    
    🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
    
    ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
    
    🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.
    
    ---
    
     - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
    
    ---
    
    This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
    <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40OS4wIiwidXBkYXRlZEluVmVyIjoiMzYuNDkuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
    cq-bot authored Aug 17, 2023
    1 Configuration menu
    Copy the full SHA
    e1ea578 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. fix: Bring back plugin validation (#1108)

    
    Fixes #1106
    
    Plugin validation was removed in https://github.com/cloudquery/plugin-sdk/pull/984/files#diff-95f04007d983a3bfdb080b338b9de5a8bbd73a3d65910fbe664f97788a9021b3.
    
    As a result we don't validate tables and columns anymore, see resulted bug in cloudquery/cloudquery#12428.
    
    This PR brings it back and per a better option puts the validation in the `Init` method. Other options:
    1. Have each plugin call `.validate` on the plugin side, probably after transformation [here](https://github.com/cloudquery/cloudquery/blob/03fae6d803a4e2ac00ff83d9e90a4169b247c346/plugins/source/aws/resources/plugin/tables.go#L565). Downside that each plugin needs to implement the call
    2. Have the validation done as a part of `schema.TransformTables` [here](https://github.com/cloudquery/plugin-sdk/blob/8a6a2cc87e303d66c810e629a497f9acd3c4982c/transformers/tables.go#L30). Downside it will happen before any custom transformation that are executed on tables like [`titleTransformer`](https://github.com/cloudquery/cloudquery/blob/03fae6d803a4e2ac00ff83d9e90a4169b247c346/plugins/source/aws/resources/plugin/tables.go#L567)
    
    > Please note that before it was removed `validate` was called during `NewPlugin` which means it errored right after calling the `serve` command, meaning the plugin would not start. With this fix the plugin will error out during `Init`, which means you need to run `sync/migrate` to see the error
    
    ---
    erezrokah authored Aug 18, 2023
    1 Configuration menu
    Copy the full SHA
    61765a7 View commit details
    Browse the repository at this point in the history
  2. chore(main): Release v4.5.1 (#1146)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ## [4.5.1](v4.5.0...v4.5.1) (2023-08-18)
    
    
    ### Bug Fixes
    
    * Bring back plugin validation ([#1108](#1108)) ([61765a7](61765a7))
    * **deps:** Update module github.com/cloudquery/plugin-pb-go to v1.9.3 ([#1149](#1149)) ([e1ea578](e1ea578))
    * **deps:** Update module github.com/cloudquery/plugin-sdk/v4 to v4.5.0 ([#1145](#1145)) ([70d12e4](70d12e4))
    
    ---
    This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
    cq-bot authored Aug 18, 2023
    1 Configuration menu
    Copy the full SHA
    2e01af2 View commit details
    Browse the repository at this point in the history
Loading