fix: Create docker container with Tty true#87
Merged
kodiakhq[bot] merged 1 commit intomainfrom Aug 17, 2023
Merged
Conversation
hermanschaaf
approved these changes
Aug 17, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 17, 2023
🤖 I have created a release *beep* *boop* --- ## [1.9.3](v1.9.2...v1.9.3) (2023-08-17) ### Bug Fixes * Create docker container with Tty true ([#87](#87)) ([4c70f9a](4c70f9a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #86
See docs https://pkg.go.dev/github.com/docker/docker@v20.10.25+incompatible/client#Client.ContainerLogs
This means we'll only read
stdoutfrom the container (I think that's OK). If we wantstderrwe'll need to demultiplex the stream, seeUse the following steps to ensure your PR is ready to be reviewed
go fmt ./...to format your code 🖊golangci-lint run🚨 (install golangci-lint here)