Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.11.0
Choose a base ref
...
head repository: cloudquery/plugin-sdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.11.1
Choose a head ref
  • 5 commits
  • 7 files changed
  • 4 contributors

Commits on Dec 6, 2022

  1. fix(sentry): Use HTTPSyncTransport, remove flush (#465)

    
    This PR switches Sentry to work in synchronous mode (like we have in the [CLI](https://github.com/cloudquery/cloudquery/blob/a98e20d3c13b4f9a4ef3a08cf00daa48648935fe/cli/cmd/sentry.go#L10)).
    
    We can't rely on `sentry.Flush` begin called in a consistent way, especially on Windows since it doesn't support sending an interrupt signal and kills the process immediately:
    https://github.com/cloudquery/plugin-sdk/blob/464f75f0b586def0c85a501dccc9e6235eebff0e/clients/source_terminate_windows.go#L6
    
    This might have a performance tradeoff, but since we use it for errors/panics only we think that should be ok.
    Another solution @disq suggested would be to call `sentry.Flush` after the `sync` for example in source plugins. 
    
    ---
    erezrokah authored Dec 6, 2022
    1 Configuration menu
    Copy the full SHA
    4d48306 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. fix(codegen)!: Column type for slices (#447)

    #### Summary
    
    * `[]*string` will become `schema.TypeStringArray`
    * `[]*int(8|16|32|64)` will become `schema.TypeIntArray`
    
    ---
    candiduslynx authored Dec 7, 2022
    1 Configuration menu
    Copy the full SHA
    7474c90 View commit details
    Browse the repository at this point in the history
  2. fix: Concurrent read,write to a map (#467)

    Im not sure how we didn't hit this before but I was able to hit this while working on azure number of times. Prob will need another set of eye to make sure it's good now.
    yevgenypats authored Dec 7, 2022
    1 Configuration menu
    Copy the full SHA
    ebef24a View commit details
    Browse the repository at this point in the history
  3. 1 Configuration menu
    Copy the full SHA
    5efe564 View commit details
    Browse the repository at this point in the history
  4. chore(main): Release v1.11.1 (#466)

    🤖 I have created a release *beep* *boop*
    ---
    
    
    ## [1.11.1](v1.11.0...v1.11.1) (2022-12-07)
    
    
    ### Bug Fixes
    
    * **codegen:** Column type for slices ([7474c90](7474c90))
    * Concurrent read,write to a map ([#467](#467)) ([ebef24a](ebef24a))
    * **sentry:** Use HTTPSyncTransport, remove flush ([#465](#465)) ([4d48306](4d48306))
    * Skip relations when initializing metrics ([#469](#469)) ([5efe564](5efe564))
    
    ---
    This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
    cq-bot authored Dec 7, 2022
    2 Configuration menu
    Copy the full SHA
    e34cb2c View commit details
    Browse the repository at this point in the history
Loading